Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pointer analysis: Replace uses of namespacet::follow #8231

Merged

Conversation

tautschnig
Copy link
Collaborator

This is deprecated. Use suitable variants of follow_tag instead.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig self-assigned this Mar 6, 2024
@tautschnig tautschnig force-pushed the cleanup/no-follow-pointer-analysis branch 2 times, most recently from bd1c878 to b75021e Compare March 19, 2024 13:31
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 83.78378% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 79.64%. Comparing base (facb34d) to head (7241dd9).

❗ Current head 7241dd9 differs from pull request most recent head 0332e47. Consider uploading reports for the commit 0332e47 to get more accurate results

Files Patch % Lines
src/pointer-analysis/value_set.cpp 82.05% 7 Missing ⚠️
src/pointer-analysis/value_set_fi.cpp 80.00% 3 Missing ⚠️
src/pointer-analysis/value_set_analysis_fi.cpp 81.81% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8231      +/-   ##
===========================================
+ Coverage    77.96%   79.64%   +1.67%     
===========================================
  Files         1720     1684      -36     
  Lines       188982   195679    +6697     
  Branches     18391        0   -18391     
===========================================
+ Hits        147344   155852    +8508     
+ Misses       41638    39827    -1811     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tautschnig tautschnig marked this pull request as ready for review March 19, 2024 14:32
@tautschnig tautschnig force-pushed the cleanup/no-follow-pointer-analysis branch 2 times, most recently from 653ec59 to 7241dd9 Compare March 22, 2024 19:44
This is deprecated. Use suitable variants of `follow_tag` instead.
@tautschnig tautschnig force-pushed the cleanup/no-follow-pointer-analysis branch from 7241dd9 to 0332e47 Compare April 30, 2024 11:25
@martin-cs martin-cs removed their assignment May 5, 2024
@tautschnig tautschnig merged commit ae7d311 into diffblue:develop May 6, 2024
37 of 38 checks passed
@tautschnig tautschnig deleted the cleanup/no-follow-pointer-analysis branch May 6, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants