Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename follow_struct_or_union_tag to follow_tag #8251

Merged

Conversation

tautschnig
Copy link
Collaborator

With the new struct_or_union_tag_typet the API is entirely consistent with the other follow_tag variants. Invoking
follow_struct_or_union_tag(to_struct_or_union_tag_type(t)) just made for awkwardly looking code.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

With the new `struct_or_union_tag_typet` the API is entirely consistent
with the other `follow_tag` variants. Invoking
`follow_struct_or_union_tag(to_struct_or_union_tag_type(t))` just made
for awkwardly looking code.
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 79.64%. Comparing base (e7b0557) to head (bb8d706).

Files Patch % Lines
src/util/namespace.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8251   +/-   ##
========================================
  Coverage    79.64%   79.64%           
========================================
  Files         1684     1684           
  Lines       195670   195670           
========================================
  Hits        155841   155841           
  Misses       39829    39829           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tautschnig tautschnig merged commit d7b229e into diffblue:develop Mar 22, 2024
39 of 40 checks passed
@tautschnig tautschnig deleted the cleanup/fixup-follow-struct-union-tag branch March 22, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants