Add IEEE 754 TiesToAway rounding mode #8515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
force-pushed
the
TiesToAway
branch
3 times, most recently
from
278c8af to
5e5f9ee
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8515 +/- ##
===========================================
- Coverage 79.60% 79.14% -0.46%
===========================================
Files 1733 1733
Lines 197358 198512 +1154
Branches 18165 18173 +8
===========================================
+ Hits 157111 157119 +8
- Misses 40247 41393 +1146 ☔ View full report in Codecov by Sentry. |
kroening
requested review from
martin-cs,
peterschrammel,
TGWDB and
tautschnig
as code owners
kroening
force-pushed
the
TiesToAway
branch
2 times, most recently
from
6f246fe to
5de7b26
Compare
peterschrammel
approved these changes
Feb 4, 2025
kroening
force-pushed
the
TiesToAway
branch
2 times, most recently
from
7849525 to
e4647d8
Compare
tautschnig
requested changes
Feb 7, 2025
src/solvers/smt2/smt2_conv.cpp
Outdated
| // TODO: add some kind of error checking here | ||
| out << "roundTowardZero"; | ||
| out << "roundTowardAway"; |
There was a problem hiding this comment.
Shouldn't this be RoundNearestTiesToAway?
This adds IEEE 754 TiesToAway rounding mode, which rounds away from zero in case of a tie. The rounding mode is added to three distinct implementations: 1. The implementation for constants, in util/ieee_float.h 2. The implementation that creates a bit-level encoding, in src/solvers/floatbv/float_utils.h. 3. The implementation that creates a word-level encoding, in solvers/floatbv/float_bv.cpp.
tautschnig
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds IEEE 754 TiesToAway rounding mode, which rounds away from zero in case of a tie.