Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMT2: relations on the range type #8523

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

kroening
Copy link
Member

@kroening kroening commented Dec 1, 2024

The range type is encoded using binary (using an offset for negative numbers). This adds support for <, <=, >, >= over the range type to the SMT2 backend.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

The range type is encoded using binary (using an offset for negative
numbers).  This adds support for <, <=, >, >= over the range type to the
SMT2 backend.
Copy link

codecov bot commented Dec 1, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.74%. Comparing base (ee8d275) to head (6109869).
Report is 11 commits behind head on develop.

Files with missing lines Patch % Lines
src/solvers/smt2/smt2_conv.cpp 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8523      +/-   ##
===========================================
- Coverage    78.93%   78.74%   -0.19%     
===========================================
  Files         1728     1728              
  Lines       198550   199020     +470     
  Branches     18372    18392      +20     
===========================================
+ Hits        156719   156720       +1     
- Misses       41831    42300     +469     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kroening kroening marked this pull request as ready for review December 1, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants