Methods for parsing a full snapshot #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jknack
reviewed
Aug 23, 2023
jknack
reviewed
Aug 23, 2023
|
🔔 updated with initial implementation of SnapshotReader/SnapshotFile |
…shot. The "lens" gets tacked on as an extra value. I made a mistake when generating the test data, you did a great job making the parser resilient to that. The parser can probably be a little simpler if we error out for lenses that are missing their root.
|
I made a mistake in one of the test cases that made the parser more complicated than it otherwise needed to be. Fixed above. Ranked importance of tasks right now:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of
SnapshotReaderandSnapshotFile#5After this PR is done, we'll start actually making and checking against snapshots on disk. Suuuuuper speculative look at that here:
a4ba0f3