-
Notifications
You must be signed in to change notification settings - Fork 1
feat: create app to get diffpy.cmi version #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Had to force-push because of conflicts i missed in pre-commit. |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
@sbillinge @bobleesj Is there any reason why we dont have this baked in to scikit-package? this seems like a simple and useful tool. |
of Python modules for robust modeling of nanostructures in crystals, | ||
nanomaterials, and amorphous materials. | ||
|
||
Docs: https://www.diffpy.org/diffpy.cmi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link is broken right now, but in the future this will be the link we use
@sbillinge This general format I got from pdfgui and chatGPT. ready for review |
I can't merge with a force-push. I am afraid we have to do it over. Of course I don't have to tell you to be running pre-commit locally to avoid conflicts, but a simple Re @bobleesj, it does seem like the --version behavior would be good to have in skpkg |
closes #7
New CLI commands
-V
and-h
. Also link to docs is presented.