Skip to content

feat: create app to get diffpy.cmi version #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

cadenmyers13
Copy link
Contributor

@cadenmyers13 cadenmyers13 commented Jun 30, 2025

closes #7

New CLI commands -V and -h. Also link to docs is presented.

Screenshot 2025-06-30 at 3 43 20 PM

@cadenmyers13
Copy link
Contributor Author

Had to force-push because of conflicts i missed in pre-commit.

Copy link

codecov bot commented Jun 30, 2025

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@cadenmyers13
Copy link
Contributor Author

cadenmyers13 commented Jun 30, 2025

@sbillinge @bobleesj Is there any reason why we dont have this baked in to scikit-package? this seems like a simple and useful tool.

of Python modules for robust modeling of nanostructures in crystals,
nanomaterials, and amorphous materials.

Docs: https://www.diffpy.org/diffpy.cmi
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link is broken right now, but in the future this will be the link we use

@cadenmyers13
Copy link
Contributor Author

@sbillinge This general format I got from pdfgui and chatGPT. ready for review

@sbillinge
Copy link
Contributor

I can't merge with a force-push. I am afraid we have to do it over. Of course I don't have to tell you to be running pre-commit locally to avoid conflicts, but a simple git pull from your origin will get the CI induced pre-commit changes. If you have a default setting that git pull does a rebase and not a merge, then change your settings...... Then you won't generate a force-push.

Re @bobleesj, it does seem like the --version behavior would be good to have in skpkg

@cadenmyers13 cadenmyers13 deleted the create-app branch July 1, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create a very tiny app in diffpy.cmi
2 participants