Skip to content

skpkg (redo): setup CI after migrating tests, src, requirements, and .github folder #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 18, 2025

Conversation

tinatn29
Copy link

No description provided.

@tinatn29
Copy link
Author

tinatn29 commented Jun 18, 2025

CI failing because of the variable name cutted. @sbillinge @cadenmyers13 We said we didn't want to add it to .codespell/ignore_texts?

Copy link

codecov bot commented Jun 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.78%. Comparing base (c17c8e3) to head (966bb4b).
Report is 10 commits behind head on migration.

Additional details and impacted files
@@            Coverage Diff             @@
##           migration      #82   +/-   ##
==========================================
  Coverage      93.78%   93.78%           
==========================================
  Files              4        4           
  Lines            177      177           
==========================================
  Hits             166      166           
  Misses            11       11           
Files with missing lines Coverage Δ
tests/test_version.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sbillinge
Copy link
Contributor

CI failing because of the variable name cutted. @sbillinge @cadenmyers13 We said we didn't want to add it to .codespell/ignore_texts?

I will merge with it failing this. Please make an issue to change that variable name and we can make a PR to do that.

The purpose of this exercise is to make our code better, so finding a problem and not fixing it is not allowed. The point is not to keep updating our tests until our bad code passes them, but rather for the tests to force our code to be better.....

@sbillinge sbillinge merged commit 79eba50 into diffpy:migration Jun 18, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants