Skip to content

Conversation

Frankiecesco510
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Aug 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.31%. Comparing base (d61ee4e) to head (ab9e110).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #201   +/-   ##
=======================================
  Coverage   99.31%   99.31%           
=======================================
  Files           5        5           
  Lines         292      292           
=======================================
  Hits          290      290           
  Misses          2        2           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sbillinge
Copy link
Contributor

haha, that worked! put a few words in comments saying what this PR is about.

I don't think we need this example app actually because this package already has some apps.

Also, are we putting these commits into the migration branch or directly into main? I think we should use migration as the base branch. In that case the PR would be into migration and not into main. This can be changed by clicking edit at the top next to the title of the PR.

We use a naming scheme where we start with a tag of what the PR is about, so this could docs:, feat:, chore:, fix:, for example. feat is for a new feature (you won't be doing any of those yet), fix is a bug fix, chore is for things like changing README.md to README.rst and other "chores" like that.

So a good title for this PR might be "feat: add an example app for this package", except we don't want that new "feature" so no ned to edit this one. I will close it shortly.

But congrats! You made it all the way to a PR. I know this has been a harrowing journey. Don't worry, it will get easier the more you do it!

@Frankiecesco510 Frankiecesco510 closed this by deleting the head repository Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants