Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable arguments-differ #508

Merged
merged 1 commit into from
Apr 20, 2024
Merged

Enable arguments-differ #508

merged 1 commit into from
Apr 20, 2024

Conversation

MizukiTemma
Copy link
Member

Short description

This PR enalbes arguments-differ check in Pylint.

Proposed changes

  • Enalbe arguments-differ global

Resolved issues

Fixes: (#499 , partially)

@MizukiTemma MizukiTemma requested a review from a team as a code owner January 25, 2024 15:20
@MizukiTemma MizukiTemma mentioned this pull request Jan 25, 2024
Open
10 tasks
JoeyStk
JoeyStk approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@JoeyStk JoeyStk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I did some manual testing and while testing the main functions (creating, updating, deleting vocabularies, modules and disciplines, and updating and creating users & sponsors) I didn't encounter any issues

svenseeberg
svenseeberg approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@svenseeberg svenseeberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MizukiTemma MizukiTemma merged commit 71d83a0 into develop Apr 20, 2024
1 check passed
@MizukiTemma MizukiTemma deleted the pylint_rules_3 branch April 20, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svenseeberg svenseeberg svenseeberg approved these changes

@JoeyStk JoeyStk JoeyStk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MizukiTemma @svenseeberg @JoeyStk