This repository has been archived by the owner on Feb 9, 2019. It is now read-only.
class and include_predecessor_id paramters added #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| extend ClassMethods | ||
| include InstanceMethods | ||
|
|
||
| class_attribute :_predecessor_klass, :_predecessor_symbol | ||
| self._predecessor_symbol = predecessor_symbol | ||
| self._predecessor_klass = Object.const_get(predecessor_symbol.to_s.capitalize) | ||
| if defined? params and not params.nil? and defined? params[:class] and not params[:class].nil? then |
There was a problem hiding this comment.
As I read it, you are asking two things: (A) Is the params hash present, and (B) Is the params[:class] present. So why not simply ask params[:class].present?
|
Please try to address the concerns that @ekampp pointed out |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I've added a :class => "::Namespace::ClassName" parameter to acts_as_heir_of to be able to inherit classes from other namespace. This also fixes a bug when the predecessor class name was camelized (like: ActivityItem).
And I've added a :include_predecessor_id => true parameter what adds {predecessor_name}_id as an attribute to the child class.
Regards, David