Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(directus module) add error handling #97

Merged
merged 5 commits into from
Jul 18, 2024
Merged

refactor(directus module) add error handling #97

merged 5 commits into from
Jul 18, 2024

Conversation

ComfortablyCoding
Copy link
Contributor

@ComfortablyCoding ComfortablyCoding commented Jul 17, 2024 •
edited
Loading

Scope

What's changed:

  • Added error handling for redirect and global fetch in directus module.
  • Added a default baseUrl based on default directus HOST and PORT values.

Potential Risks / Drawbacks

  • None

Review Notes / Questions

  • This does not fix pnpm i fails #68 as the underlying cause in the original report is unclear. It does prevent the module from fatally erroring which should improve DX. The 2 causes I saw for this issue are listed below, I was not able to reproduce the undefined error in the original report
    • Invalid DIRECTUS_URL
    • The Directus instance is unreachable

Related: #68

@netlify Netlify
Copy link

netlify bot commented Jul 17, 2024 •
edited
Loading

✅ Deploy Preview for agency-os ready!

Name Link
🔨 Latest commit 9f6cb9b
🔍 Latest deploy log https://app.netlify.com/sites/agency-os/deploys/66993432a5ab460008ff5393
😎 Deploy Preview https://deploy-preview-97--agency-os.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vercel Vercel
Copy link

vercel bot commented Jul 17, 2024

@ComfortablyCoding is attempting to deploy a commit to the Directus Team on Vercel.

A member of the Team first needs to authorize it.

@ComfortablyCoding ComfortablyCoding self-assigned this Jul 18, 2024
@ComfortablyCoding ComfortablyCoding added the bug Something isn't working label Jul 18, 2024
@ComfortablyCoding ComfortablyCoding merged commit 019fd3c into directus-labs:main Jul 18, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@w0kyj w0kyj w0kyj approved these changes

Assignees

@ComfortablyCoding ComfortablyCoding

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pnpm i fails
2 participants
@ComfortablyCoding @w0kyj