chore: use biome for formatting and linting #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sklein12
reviewed
May 17, 2024
Comment on lines
+10
to
+24
| app.post( | ||
| '/interactions', | ||
| verifyKeyMiddleware(process.env.CLIENT_PUBLIC_KEY), | ||
| (req, res) => { | ||
| const interaction = req.body; | ||
| if (interaction.type === InteractionType.APPLICATION_COMMAND) { | ||
| res.send({ | ||
| type: InteractionResponseType.CHANNEL_MESSAGE_WITH_SOURCE, | ||
| data: { | ||
| content: 'Hello world', | ||
| }, | ||
| }); | ||
| } | ||
| }, | ||
| ); |
There was a problem hiding this comment.
I'm not a fan of this tab size, can you make this match discord_app of 2?
There was a problem hiding this comment.
Chatted through in DM - this is using tabs by default instead of spaces. I believe tab size is entirely controlled via editor, but the default config is a tabsize of 2 FWIW.
There was a problem hiding this comment.
So this reformatted the entire codebase in tabs instead of spaces?
nice
colinloretz
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading eslint/prettier has become increasingly annoying, and https://biomejs.dev/ is gaining some early traction. I'd like to use it here, where there is relatively low risk.