Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken test.sh node image replacement logic #162

Merged
merged 3 commits into from
Jul 24, 2024

Conversation

donstephan
Copy link
Contributor

This fixes tests for PR #161. The test.sh file did not handle swapping in the node image maintained by meteor for version 14.21.4.

This fixes tests for PR disney#161. The test.sh file did not handle swapping in the node image maintained by meteor for version 14.21.4.
@donstephan
Copy link
Contributor Author

Output includes which registry it's using:

Output from 2.16: https://github.com/disney/meteor-base/actions/runs/10078450028/job/27863413913?pr=162

Testing Docker image geoffreybooth/meteor-base:2.16...
Creating test app...
Using Meteor fork of Node Docker image...
Building test app Docker image...
Launching test app...
Running test...
PASS for geoffreybooth/meteor-base:2.16 with meteor/node:14.21.4-alpine3.17 after 1 min 53 sec
PASS! All images passed the test

Output from 2.9.1: https://github.com/disney/meteor-base/actions/runs/10078450028/job/27863409388?pr=162

Testing Docker image geoffreybooth/meteor-base:2.9.1...
Creating test app...
Using official Node Docker image...
Building test app Docker image...
Launching test app...
Running test...
PASS for geoffreybooth/meteor-base:2.[9](https://github.com/disney/meteor-base/actions/runs/10078450028/job/27863409388?pr=162#step:4:10).1 with node:14.21.2-alpine after 1 min 36 sec
PASS! All images passed the test

test.sh Outdated Show resolved Hide resolved
@GeoffreyBooth GeoffreyBooth merged commit 255ecd1 into disney:main Jul 24, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants