Fix offset calculation in hover box. #105
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Gosh! Thank you for the lovely PR. GIFs in the description is lovely. I'll defer to @ludwigschubert on code review, just wanted to comment because you'd handled that so nicely. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the offset of a hover box is calculated based on
offsetLeftandoffsetTop. However, both attributes are relative to the parent, so the citations and footnotes in a table (or other nested elements) may be placed incorrectly.This patch calculates the offset by recursively adding up the offsets of parents. Now the hover boxes appear at the right place.