Improve code quality #382
Merged
Improve code quality #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes made: ✅ ui/src/district/graphql_utils.cljs:184:29: warning: unused binding description ✅ ui/src/ethlance/ui/component/chat.cljs:59:8: warning: redundant do ✅ ui/src/ethlance/ui/component/file_drag_input.cljs:22:31: warning: Missing else branch. ✅ ui/src/ethlance/ui/component/main_layout.cljs:24:41: warning: Unresolved namespace clojure.string. Are you missing a require? ✅ ui/src/ethlance/ui/component/main_navigation_bar.cljs:27:9: warning: unused binding profile-image ✅ ui/src/ethlance/ui/component/main_navigation_bar.cljs:45:13: warning: unused binding active-user-id ✅ ui/src/ethlance/ui/component/main_navigation_menu.cljs:39:39: error: get-in with single key ✅ ui/src/ethlance/ui/component/main_navigation_menu.cljs:9:35: warning: #'re-frame.core/subscribe is referred but never used ✅ ui/src/ethlance/ui/component/mobile_sidebar.cljs:2:3: warning: Docstring should not be blank. ✅ ui/src/ethlance/ui/component/pagination.cljs:77:11: warning: unused binding current-page ✅ ui/src/ethlance/ui/component/scrollable.cljs:31:13: warning: unused binding this ✅ ui/src/ethlance/ui/component/search_input.cljs:94:13: warning: unused binding this ✅ ui/src/ethlance/ui/component/token_amount_input.cljs:14:20: warning: Unresolved namespace cljs.math. Are you missing a require? ✅ ui/src/ethlance/ui/component/token_amount_input.cljs:5:6: warning: namespace reagent.core is required but never used ✅ ui/src/ethlance/ui/component/token_info.cljs:18:13: warning: Unresolved namespace clojure.string. Are you missing a require? ✅ ui/src/ethlance/ui/component/token_info.cljs:32:23: warning: Missing else branch. ✅ ui/src/ethlance/ui/config.cljs:11:57: warning: #'ethlance.shared.utils/slurp is referred but never used ✅ ui/src/ethlance/ui/config.cljs:12:30: warning: #'taoensso.timbre/merge-config! is referred but never used ✅ ui/src/ethlance/ui/config.cljs:12:6: warning: namespace taoensso.timbre is required but never used ✅ ui/src/ethlance/ui/config.cljs:5:6: warning: namespace ethlance.shared.config is required but never used ✅ ui/src/ethlance/ui/core.cljs:41:3: warning: Redundant let expression. ✅ ui/src/ethlance/ui/event/sign_in.cljs:45:23: error: assoc-in with single key ✅ ui/src/ethlance/ui/event/sign_in.cljs:46:23: error: assoc-in with single key ✅ ui/src/ethlance/ui/events.cljs:31:19: warning: unused binding store ✅ ui/src/ethlance/ui/page/arbiters.cljs:110:39: error: get-in with single key ✅ ui/src/ethlance/ui/page/arbiters/events.cljs:30:21: error: assoc-in with single key ✅ ui/src/ethlance/ui/page/arbiters/events.cljs:4:6: warning: namespace district.ui.router.effects is required but never used ✅ ui/src/ethlance/ui/page/arbiters/events.cljs:5:6: warning: namespace ethlance.shared.constants is required but never used ✅ ui/src/ethlance/ui/page/arbiters/subscriptions.cljs:34:19: error: get-in with single key ✅ ui/src/ethlance/ui/page/candidates.cljs:20:6: warning: namespace ethlance.ui.component.radio-select is required but never used ✅ ui/src/ethlance/ui/page/candidates.cljs:22:37: warning: #'ethlance.ui.component.radio-select/c-radio-select is referred but never used ✅ ui/src/ethlance/ui/page/candidates.cljs:22:7: warning: #'ethlance.ui.component.radio-select/c-radio-search-filter-element is referred but never used ✅ ui/src/ethlance/ui/page/candidates/events.cljs:27:21: error: assoc-in with single key ✅ ui/src/ethlance/ui/page/candidates/events.cljs:4:6: warning: namespace district.ui.router.effects is required but never used ✅ ui/src/ethlance/ui/page/candidates/events.cljs:5:6: warning: namespace ethlance.shared.constants is required but never used ✅ ui/src/ethlance/ui/page/candidates/subscriptions.cljs:35:19: error: get-in with single key ✅ ui/src/ethlance/ui/page/dev/contract_ops.cljs:144:28: warning: Missing else branch. ✅ ui/src/ethlance/ui/page/dev/contract_ops.cljs:148:22: warning: Unresolved namespace cljs.pprint. Are you missing a require? ✅ ui/src/ethlance/ui/page/dev/contract_ops.cljs:157:9: warning: unused binding selected-token ✅ ui/src/ethlance/ui/page/dev/contract_ops.cljs:165:54: warning: Unresolved namespace ethlance.ui.config. Are you missing a require? ✅ ui/src/ethlance/ui/page/dev/contract_ops.cljs:46:8: warning: unused binding db ✅ ui/src/ethlance/ui/page/dev/contract_ops.cljs:53:22: warning: Unresolved namespace district.ui.web3-accounts.queries. Are you missing a require? ✅ ui/src/ethlance/ui/page/dev/contract_ops.cljs:5:6: warning: namespace district.ui.router.subs is required but never used ✅ ui/src/ethlance/ui/page/dev/contract_ops.cljs:8:48: warning: #'ethlance.ui.component.main-layout/c-main-layout is referred but never used ✅ ui/src/ethlance/ui/page/dev/contract_ops.cljs:8:6: warning: namespace ethlance.ui.component.main-layout is required but never used ✅ ui/src/ethlance/ui/page/dev/contract_ops.cljs:9:49: warning: #'ethlance.ui.component.select-input/c-select-input is referred but never used ✅ ui/src/ethlance/ui/page/dev/contract_ops.cljs:9:6: warning: namespace ethlance.ui.component.select-input is required but never used ✅ ui/src/ethlance/ui/page/home/events.cljs:18:3: warning: Redundant let expression. ✅ ui/src/ethlance/ui/page/invoices.cljs:100:55: error: get-in with single key ✅ ui/src/ethlance/ui/page/invoices.cljs:101:54: error: get-in with single key ✅ ui/src/ethlance/ui/page/invoices.cljs:12:37: warning: #'ethlance.ui.util.dates/relative-ago is referred but never used ✅ ui/src/ethlance/ui/page/invoices.cljs:14:6: warning: namespace ethlance.ui.util.tokens is required but never used ✅ ui/src/ethlance/ui/page/invoices.cljs:22:17: warning: Unresolved namespace clojure.string. Are you missing a require? ✅ ui/src/ethlance/ui/page/invoices.cljs:26:37: error: get-in with single key ✅ ui/src/ethlance/ui/page/invoices.cljs:5:6: warning: namespace district.ui.router.subs is required but never used ✅ ui/src/ethlance/ui/page/invoices.cljs:6:6: warning: namespace ethlance.shared.utils is required but never used ✅ ui/src/ethlance/ui/page/invoices.cljs:81:11: warning: unused binding job-token-symbol ✅ ui/src/ethlance/ui/page/invoices.cljs:83:11: warning: unused binding job-title ✅ ui/src/ethlance/ui/page/invoices.cljs:84:31: error: get-in with single key ✅ ui/src/ethlance/ui/page/invoices.cljs:85:32: error: get-in with single key ✅ ui/src/ethlance/ui/page/invoices.cljs:86:31: error: get-in with single key ✅ ui/src/ethlance/ui/page/invoices.cljs:96:57: error: get-in with single key ✅ ui/src/ethlance/ui/page/invoices/events.cljs:10:6: warning: namespace ethlance.ui.util.tokens is required but never used ✅ ui/src/ethlance/ui/page/invoices/events.cljs:43:16: warning: unused binding db ✅ ui/src/ethlance/ui/page/invoices/events.cljs:45:5: warning: Redundant let expression. ✅ ui/src/ethlance/ui/page/invoices/events.cljs:55:11: warning: unused binding invoice-fields ✅ ui/src/ethlance/ui/page/invoices/events.cljs:79:8: warning: unused binding db ✅ ui/src/ethlance/ui/page/invoices/events.cljs:7:6: warning: namespace district.ui.web3.queries is required but never used ✅ ui/src/ethlance/ui/page/invoices/events.cljs:84:8: warning: unused binding db ✅ ui/src/ethlance/ui/page/invoices/events.cljs:8:36: warning: #'ethlance.shared.utils/eth->wei is referred but never used ✅ ui/src/ethlance/ui/page/invoices/events.cljs:96:11: warning: unused binding event ✅ ui/src/ethlance/ui/page/invoices/events.cljs:96:8: warning: unused binding db ✅ ui/src/ethlance/ui/page/job_contract.cljs:105:9: warning: unused binding job-story-id ✅ ui/src/ethlance/ui/page/job_contract.cljs:200:10: warning: unused binding job-story-id ✅ ui/src/ethlance/ui/page/job_contract.cljs:206:15: warning: unused binding feedback-recipients ✅ ui/src/ethlance/ui/page/job_contract.cljs:210:9: warning: unused binding feedback-recipient ✅ ui/src/ethlance/ui/page/job_contract.cljs:242:32: warning: unused binding participants ✅ ui/src/ethlance/ui/page/job_contract.cljs:289:9: warning: unused binding new-feedback-recipients ✅ ui/src/ethlance/ui/page/job_contract.cljs:335:56: warning: Unresolved namespace clojure.string. Are you missing a require? ✅ ui/src/ethlance/ui/page/job_contract.cljs:358:9: warning: unused binding result ✅ ui/src/ethlance/ui/page/job_contract.cljs:410:5: warning: unused binding job-story-status ✅ ui/src/ethlance/ui/page/job_contract.cljs:412:5: warning: unused binding employer ✅ ui/src/ethlance/ui/page/job_contract.cljs:413:5: warning: unused binding arbiter ✅ ui/src/ethlance/ui/page/job_contract.cljs:414:5: warning: unused binding candidate ✅ ui/src/ethlance/ui/page/job_contract.cljs:415:5: warning: unused binding current-user-role ✅ ui/src/ethlance/ui/page/job_contract.cljs:417:9: warning: unused binding active-user ✅ ui/src/ethlance/ui/page/job_contract.cljs:466:65: error: get-in with single key ✅ ui/src/ethlance/ui/page/job_contract.cljs:473:63: error: get-in with single key ✅ ui/src/ethlance/ui/page/job_contract.cljs:474:9: warning: unused binding dispute-available? ✅ ui/src/ethlance/ui/page/job_contract.cljs:699:13: warning: unused binding human-amount ✅ ui/src/ethlance/ui/page/job_contract.cljs:702:48: error: get-in with single key ✅ ui/src/ethlance/ui/page/job_contract.cljs:94:14: warning: unused binding amount-field ✅ ui/src/ethlance/ui/page/job_contract.cljs:95:9: warning: unused binding amount ✅ ui/src/ethlance/ui/page/job_contract.cljs:98:9: warning: unused binding token-name ✅ ui/src/ethlance/ui/page/job_contract.cljs:99:9: warning: unused binding token-symbol ✅ ui/src/ethlance/ui/page/job_contract/events.cljs:135:77: warning: unused binding event ✅ ui/src/ethlance/ui/page/job_contract/events.cljs:13:36: warning: #'ethlance.shared.utils/eth->wei is referred but never used ✅ ui/src/ethlance/ui/page/job_contract/events.cljs:168:16: warning: unused binding db ✅ ui/src/ethlance/ui/page/job_contract/events.cljs:203:16: warning: unused binding db ✅ ui/src/ethlance/ui/page/job_contract/events.cljs:218:16: warning: unused binding db ✅ ui/src/ethlance/ui/page/job_contract/events.cljs:218:21: warning: unused binding event ✅ ui/src/ethlance/ui/page/job_contract/events.cljs:230:22: warning: unused binding event-name ✅ ui/src/ethlance/ui/page/job_contract/events.cljs:3:6: warning: namespace web3 is required but never used ✅ ui/src/ethlance/ui/page/job_contract/events.cljs:43:16: warning: unused binding db ✅ ui/src/ethlance/ui/page/job_contract/events.cljs:86:12: warning: unused binding db ✅ ui/src/ethlance/ui/page/job_contract/subscriptions.cljs:4:6: warning: namespace district.ui.graphql.queries is required but never used ✅ ui/src/ethlance/ui/page/job_contract/subscriptions.cljs:6:36: warning: #'ethlance.shared.utils/ilike= is referred but never used ✅ ui/src/ethlance/ui/page/job_contract/subscriptions.cljs:6:6: warning: namespace ethlance.shared.utils is required but never used ✅ ui/src/ethlance/ui/page/job_detail.cljs:11:7: warning: #'ethlance.ui.component.carousel/c-carousel is referred but never used ✅ ui/src/ethlance/ui/page/job_detail.cljs:12:50: warning: #'ethlance.ui.component.circle-button/c-circle-icon-button is referred but never used ✅ ui/src/ethlance/ui/page/job_detail.cljs:12:6: warning: namespace ethlance.ui.component.circle-button is required but never used ✅ ui/src/ethlance/ui/page/job_detail.cljs:134:38: error: get-in with single key ✅ ui/src/ethlance/ui/page/job_detail.cljs:137:37: error: get-in with single key ✅ ui/src/ethlance/ui/page/job_detail.cljs:138:35: error: get-in with single key ✅ ui/src/ethlance/ui/page/job_detail.cljs:139:40: error: get-in with single key ✅ ui/src/ethlance/ui/page/job_detail.cljs:140:9: warning: unused binding *job-token-amount ✅ ui/src/ethlance/ui/page/job_detail.cljs:20:49: warning: #'ethlance.ui.component.select-input/c-select-input is referred but never used ✅ ui/src/ethlance/ui/page/job_detail.cljs:20:6: warning: namespace ethlance.ui.component.select-input is required but never used ✅ ui/src/ethlance/ui/page/job_detail.cljs:210:9: warning: Missing else branch. ✅ ui/src/ethlance/ui/page/job_detail.cljs:214:9: warning: Missing else branch. ✅ ui/src/ethlance/ui/page/job_detail.cljs:248:20: warning: Unresolved namespace clojure.string. Are you missing a require? ✅ ui/src/ethlance/ui/page/job_detail.cljs:258:51: error: get-in with single key ✅ ui/src/ethlance/ui/page/job_detail.cljs:260:9: warning: unused binding arbiter-address ✅ ui/src/ethlance/ui/page/job_detail.cljs:275:72: error: get-in with single key ✅ ui/src/ethlance/ui/page/job_detail.cljs:27:41: warning: #'ethlance.ui.util.component/<sub is referred but never used ✅ ui/src/ethlance/ui/page/job_detail.cljs:311:39: error: get-in with single key ✅ ui/src/ethlance/ui/page/job_detail.cljs:312:29: warning: Unresolved namespace clojure.set. Are you missing a require? ✅ ui/src/ethlance/ui/page/job_detail.cljs:315:9: warning: unused binding arbiter-address-fn ✅ ui/src/ethlance/ui/page/job_detail.cljs:319:28: error: Unresolved symbol: clojure ✅ ui/src/ethlance/ui/page/job_detail.cljs:31:6: warning: duplicate require of ethlance.ui.util.tokens ✅ ui/src/ethlance/ui/page/job_detail.cljs:360:57: error: get-in with single key ✅ ui/src/ethlance/ui/page/job_detail.cljs:36:98: warning: unused binding opts ✅ ui/src/ethlance/ui/page/job_detail.cljs:448:9: warning: unused binding arbiter-quoted-amount ✅ ui/src/ethlance/ui/page/job_detail.cljs:449:9: warning: unused binding employer-address ✅ ui/src/ethlance/ui/page/job_detail.cljs:467:64: error: get-in with single key ✅ ui/src/ethlance/ui/page/job_detail.cljs:566:9: warning: unused binding *experience ✅ ui/src/ethlance/ui/page/job_detail.cljs:588:58: error: get-in with single key ✅ ui/src/ethlance/ui/page/job_detail.cljs:589:39: error: get-in with single key ✅ ui/src/ethlance/ui/page/job_detail.cljs:590:37: error: get-in with single key ✅ ui/src/ethlance/ui/page/job_detail.cljs:6:36: warning: #'ethlance.shared.utils/millis->relative-time is referred but never used ✅ ui/src/ethlance/ui/page/job_detail.cljs:7:6: warning: duplicate require of ethlance.shared.utils ✅ ui/src/ethlance/ui/page/job_detail.cljs:87:81: error: get-in with single key ✅ ui/src/ethlance/ui/page/job_detail.cljs:89:50: error: get-in with single key ✅ ui/src/ethlance/ui/page/job_detail/events.cljs:142:11: warning: unused binding user-address ✅ ui/src/ethlance/ui/page/job_detail/events.cljs:158:11: warning: unused binding user-address ✅ ui/src/ethlance/ui/page/job_detail/events.cljs:15:6: warning: duplicate require of ethlance.shared.utils ✅ ui/src/ethlance/ui/page/job_detail/events.cljs:191:34: error: get-in with single key ✅ ui/src/ethlance/ui/page/job_detail/events.cljs:210:12: warning: unused binding db ✅ ui/src/ethlance/ui/page/job_detail/events.cljs:283:20: warning: unused binding cofx ✅ ui/src/ethlance/ui/page/job_detail/events.cljs:359:13: warning: unused binding event ✅ ui/src/ethlance/ui/page/job_detail/events.cljs:387:14: warning: unused binding event ✅ ui/src/ethlance/ui/page/job_detail/events.cljs:390:28: error: assoc-in with single key ✅ ui/src/ethlance/ui/page/job_detail/events.cljs:403:24: warning: unused binding cofx ✅ ui/src/ethlance/ui/page/job_detail/events.cljs:403:30: warning: unused binding event ✅ ui/src/ethlance/ui/page/job_detail/events.cljs:415:24: warning: unused binding cofx ✅ ui/src/ethlance/ui/page/job_detail/events.cljs:435:24: warning: unused binding cofx ✅ ui/src/ethlance/ui/page/job_detail/events.cljs:44:9: warning: unused binding page-state ✅ ui/src/ethlance/ui/page/job_detail/events.cljs:458:8: warning: unused binding cofx ✅ ui/src/ethlance/ui/page/job_detail/events.cljs:464:24: warning: unused binding cofx ✅ ui/src/ethlance/ui/page/job_detail/events.cljs:481:24: warning: unused binding cofx ✅ ui/src/ethlance/ui/page/job_detail/events.cljs:50:23: error: assoc-in with single key ✅ ui/src/ethlance/ui/page/job_detail/events.cljs:520:11: warning: unused binding tx-opts ✅ ui/src/ethlance/ui/page/job_detail/events.cljs:534:11: warning: unused binding instance ✅ ui/src/ethlance/ui/page/job_detail/events.cljs:549:22: warning: unused binding event-name ✅ ui/src/ethlance/ui/page/job_detail/events.cljs:550:11: warning: unused binding events ✅ ui/src/ethlance/ui/page/job_detail/events.cljs:550:34: error: get-in with single key ✅ ui/src/ethlance/ui/page/job_detail/events.cljs:561:11: warning: unused binding event ✅ ui/src/ethlance/ui/page/job_detail/events.cljs:76:16: warning: unused binding db ✅ ui/src/ethlance/ui/page/job_detail/events.cljs:9:46: error: Conflicting alias for district.ui.smart-contracts.queries ✅ ui/src/ethlance/ui/page/job_detail/events.cljs:9:6: warning: duplicate require of district.ui.smart-contracts.queries ✅ ui/src/ethlance/ui/page/job_detail/subscriptions.cljs:3:6: warning: namespace district.ui.conversion-rates.subs is required but never used ✅ ui/src/ethlance/ui/page/job_detail/subscriptions.cljs:68:52: error: get-in with single key ✅ ui/src/ethlance/ui/page/job_detail/subscriptions.cljs:72:40: error: get-in with single key ✅ ui/src/ethlance/ui/page/job_detail/subscriptions.cljs:74:46: error: get-in with single key ✅ ui/src/ethlance/ui/page/job_detail/subscriptions.cljs:75:42: error: get-in with single key ✅ ui/src/ethlance/ui/page/jobs.cljs:197:34: warning: unused binding event ✅ ui/src/ethlance/ui/page/jobs.cljs:30:6: warning: namespace ethlance.ui.util.tokens is required but never used ✅ ui/src/ethlance/ui/page/jobs.cljs:38:33: error: get-in with single key ✅ ui/src/ethlance/ui/page/jobs.cljs:41:34: error: get-in with single key ✅ ui/src/ethlance/ui/page/jobs.cljs:59:32: error: get-in with single key ✅ ui/src/ethlance/ui/page/jobs.cljs:62:33: error: get-in with single key ✅ ui/src/ethlance/ui/page/jobs.cljs:85:35: error: get-in with single key ✅ ui/src/ethlance/ui/page/jobs/events.cljs:34:9: warning: unused binding page-state ✅ ui/src/ethlance/ui/page/jobs/events.cljs:35:23: error: assoc-in with single key ✅ ui/src/ethlance/ui/page/jobs/events.cljs:4:6: warning: namespace district.ui.graphql.events is required but never used ✅ ui/src/ethlance/ui/page/jobs/events.cljs:5:6: warning: namespace district.ui.router.effects is required but never used ✅ ui/src/ethlance/ui/page/jobs/events.cljs:6:6: warning: namespace ethlance.shared.constants is required but never used ✅ ui/src/ethlance/ui/page/jobs/subscriptions.cljs:34:33: error: get-in with single key ✅ ui/src/ethlance/ui/page/me.cljs:16:37: warning: #'ethlance.ui.util.dates/relative-ago is referred but never used ✅ ui/src/ethlance/ui/page/me.cljs:196:9: warning: unused binding active-user ✅ ui/src/ethlance/ui/page/me.cljs:264:9: warning: unused binding active-user ✅ ui/src/ethlance/ui/page/me.cljs:316:52: error: get-in with single key ✅ ui/src/ethlance/ui/page/me.cljs:383:9: warning: unused binding arbiter-name-fn ✅ ui/src/ethlance/ui/page/me.cljs:385:68: error: get-in with single key ✅ ui/src/ethlance/ui/page/me.cljs:386:69: error: get-in with single key ✅ ui/src/ethlance/ui/page/me.cljs:395:59: error: get-in with single key ✅ ui/src/ethlance/ui/page/me.cljs:517:14: warning: unused binding page ✅ ui/src/ethlance/ui/page/me.cljs:518:14: warning: unused binding params ✅ ui/src/ethlance/ui/page/me.cljs:538:65: error: Expected: map, received: keyword. ✅ ui/src/ethlance/ui/page/me.cljs:7:43: warning: #'ethlance.ui.component.button/c-button is referred but never used ✅ ui/src/ethlance/ui/page/me.cljs:7:52: warning: #'ethlance.ui.component.button/c-button-label is referred but never used ✅ ui/src/ethlance/ui/page/me.cljs:7:6: warning: namespace ethlance.ui.component.button is required but never used ✅ ui/src/ethlance/ui/page/me.cljs:8:50: warning: #'ethlance.ui.component.circle-button/c-circle-icon-button is referred but never used ✅ ui/src/ethlance/ui/page/me.cljs:8:6: warning: namespace ethlance.ui.component.circle-button is required but never used ✅ ui/src/ethlance/ui/page/me/events.cljs:26:9: warning: unused binding page-state ✅ ui/src/ethlance/ui/page/me/events.cljs:27:23: error: assoc-in with single key ✅ ui/src/ethlance/ui/page/me/events.cljs:3:6: warning: namespace district.ui.router.effects is required but never used ✅ ui/src/ethlance/ui/page/new_invoice.cljs:54:13: warning: unused binding token-display-name ✅ ui/src/ethlance/ui/page/new_invoice/events.cljs:11:6: warning: duplicate require of district.ui.smart-contracts.queries ✅ ui/src/ethlance/ui/page/new_invoice/events.cljs:121:8: warning: unused binding db ✅ ui/src/ethlance/ui/page/new_invoice/events.cljs:126:8: warning: unused binding db ✅ ui/src/ethlance/ui/page/new_invoice/events.cljs:134:22: warning: unused binding event-name ✅ ui/src/ethlance/ui/page/new_invoice/events.cljs:138:11: warning: unused binding invoice-created ✅ ui/src/ethlance/ui/page/new_invoice/events.cljs:142:25: error: assoc-in with single key ✅ ui/src/ethlance/ui/page/new_invoice/events.cljs:147:8: warning: unused binding db ✅ ui/src/ethlance/ui/page/new_invoice/events.cljs:16:36: warning: #'ethlance.shared.utils/eth->wei is referred but never used ✅ ui/src/ethlance/ui/page/new_invoice/events.cljs:3:6: warning: namespace cljs-web3-next.eth is required but never used ✅ ui/src/ethlance/ui/page/new_invoice/events.cljs:4:6: warning: namespace cljs-web3-next.helpers is required but never used ✅ ui/src/ethlance/ui/page/new_invoice/events.cljs:60:32: error: assoc-in with single key ✅ ui/src/ethlance/ui/page/new_invoice/events.cljs:67:33: error: get-in with single key ✅ ui/src/ethlance/ui/page/new_invoice/subscriptions.cljs:35:14: warning: Single arg use of or always returns the arg itself ✅ ui/src/ethlance/ui/page/new_invoice/subscriptions.cljs:3:6: warning: namespace district.ui.conversion-rates.queries is required but never used ✅ ui/src/ethlance/ui/page/new_job.cljs:224:4: warning: unused binding user-id ✅ ui/src/ethlance/ui/page/new_job.cljs:22:6: warning: namespace ethlance.ui.page.new-job.events is required but never used ✅ ui/src/ethlance/ui/page/new_job.cljs:23:6: warning: namespace ethlance.ui.subscriptions is required but never used ✅ ui/src/ethlance/ui/page/new_job.cljs:24:41: warning: #'ethlance.ui.util.component/<sub is referred but never used ✅ ui/src/ethlance/ui/page/new_job.cljs:51:8: warning: Unused private var ethlance.ui.page.new-job/c-submit-button ✅ ui/src/ethlance/ui/page/new_job.cljs:6:6: warning: namespace district.ui.smart-contracts.queries is required but never used ✅ ui/src/ethlance/ui/page/new_job.cljs:7:6: warning: namespace district.ui.web3-tx.events is required but never used ✅ ui/src/ethlance/ui/page/new_job.cljs:97:13: warning: unused binding with-nft? ✅ ui/src/ethlance/ui/page/new_job/events.cljs:14:36: warning: #'ethlance.shared.utils/eth->wei is referred but never used ✅ ui/src/ethlance/ui/page/new_job/events.cljs:172:29: error: get-in with single key ✅ ui/src/ethlance/ui/page/new_job/events.cljs:182:24: warning: unused binding cofx ✅ ui/src/ethlance/ui/page/new_job/events.cljs:207:8: warning: unused binding cofx ✅ ui/src/ethlance/ui/page/new_job/events.cljs:213:8: warning: unused binding cofx ✅ ui/src/ethlance/ui/page/new_job/events.cljs:219:8: warning: unused binding cofx ✅ ui/src/ethlance/ui/page/new_job/events.cljs:226:8: warning: unused binding cofx ✅ ui/src/ethlance/ui/page/new_job/events.cljs:232:24: warning: unused binding cofx ✅ ui/src/ethlance/ui/page/new_job/events.cljs:257:8: warning: unused binding cofx ✅ ui/src/ethlance/ui/page/new_job/events.cljs:263:24: warning: unused binding cofx ✅ ui/src/ethlance/ui/page/new_job/events.cljs:279:4: warning: unused binding db ✅ ui/src/ethlance/ui/page/new_job/events.cljs:287:24: warning: unused binding cofx ✅ ui/src/ethlance/ui/page/new_job/events.cljs:354:8: warning: unused binding db ✅ ui/src/ethlance/ui/page/new_job/events.cljs:359:3: warning: Redundant let expression. ✅ ui/src/ethlance/ui/page/new_job/events.cljs:366:22: warning: unused binding event-name ✅ ui/src/ethlance/ui/page/new_job/events.cljs:3:6: warning: namespace web3 is required but never used ✅ ui/src/ethlance/ui/page/new_job/events.cljs:4:6: warning: namespace alphabase.hex is required but never used ✅ ui/src/ethlance/ui/page/new_job/events.cljs:64:18: error: assoc-in with single key ✅ ui/src/ethlance/ui/page/profile.cljs:100:34: error: get-in with single key ✅ ui/src/ethlance/ui/page/profile.cljs:100:78: error: get-in with single key ✅ ui/src/ethlance/ui/page/profile.cljs:101:32: error: get-in with single key ✅ ui/src/ethlance/ui/page/profile.cljs:11:43: warning: #'ethlance.shared.utils/ilike!= is referred but never used ✅ ui/src/ethlance/ui/page/profile.cljs:14:50: warning: #'ethlance.ui.component.circle-button/c-circle-icon-button is referred but never used ✅ ui/src/ethlance/ui/page/profile.cljs:14:6: warning: namespace ethlance.ui.component.circle-button is required but never used ✅ ui/src/ethlance/ui/page/profile.cljs:215:8: warning: use the idiom (seq x) rather than (not (empty? x)) ✅ ui/src/ethlance/ui/page/profile.cljs:241:30: error: get-in with single key ✅ ui/src/ethlance/ui/page/profile.cljs:264:9: warning: unused binding page-params ✅ ui/src/ethlance/ui/page/profile.cljs:481:17: warning: unused binding name ✅ ui/src/ethlance/ui/page/profile.cljs:481:22: warning: unused binding params ✅ ui/src/ethlance/ui/page/profile.cljs:485:35: warning: unused binding params ✅ ui/src/ethlance/ui/page/profile.cljs:53:30: error: get-in with single key ✅ ui/src/ethlance/ui/page/profile.cljs:54:26: error: get-in with single key ✅ ui/src/ethlance/ui/page/profile.cljs:5:6: warning: namespace district.format is required but never used ✅ ui/src/ethlance/ui/page/profile.cljs:6:6: warning: namespace district.graphql-utils is required but never used ✅ ui/src/ethlance/ui/page/profile.cljs:99:36: error: get-in with single key ✅ ui/src/ethlance/ui/page/profile/events.cljs:107:8: warning: unused binding db ✅ ui/src/ethlance/ui/page/profile/events.cljs:120:21: warning: unused binding event ✅ ui/src/ethlance/ui/page/profile/events.cljs:134:24: warning: unused binding cofx ✅ ui/src/ethlance/ui/page/profile/events.cljs:134:30: warning: unused binding event ✅ ui/src/ethlance/ui/page/profile/events.cljs:25:9: warning: unused binding page-state ✅ ui/src/ethlance/ui/page/profile/events.cljs:30:23: error: assoc-in with single key ✅ ui/src/ethlance/ui/page/profile/events.cljs:53:16: warning: unused binding db ✅ ui/src/ethlance/ui/page/profile/events.cljs:5:41: warning: #'district.ui.router.queries/active-page-params is referred but never used ✅ ui/src/ethlance/ui/page/profile/events.cljs:5:6: warning: namespace district.ui.router.queries is required but never used ✅ ui/src/ethlance/ui/page/profile/events.cljs:8:36: warning: #'ethlance.shared.utils/eth->wei is referred but never used ✅ ui/src/ethlance/ui/page/sign_up.cljs:101:8: warning: Unused private var ethlance.ui.page.sign-up/c-user-linkedin-input ✅ ui/src/ethlance/ui/page/sign_up.cljs:155:45: error: get-in with single key ✅ ui/src/ethlance/ui/page/sign_up.cljs:156:45: error: get-in with single key ✅ ui/src/ethlance/ui/page/sign_up.cljs:223:45: error: get-in with single key ✅ ui/src/ethlance/ui/page/sign_up.cljs:224:45: error: get-in with single key ✅ ui/src/ethlance/ui/page/sign_up.cljs:265:45: error: get-in with single key ✅ ui/src/ethlance/ui/page/sign_up.cljs:266:45: error: get-in with single key ✅ ui/src/ethlance/ui/page/sign_up.cljs:26:6: warning: namespace ethlance.ui.subscriptions is required but never used ✅ ui/src/ethlance/ui/page/sign_up.cljs:27:41: warning: #'ethlance.ui.util.component/<sub is referred but never used ✅ ui/src/ethlance/ui/page/sign_up.cljs:87:8: warning: Unused private var ethlance.ui.page.sign-up/c-user-github-input ✅ ui/src/ethlance/ui/page/sign_up/events.cljs:163:8: warning: unused binding cofx ✅ ui/src/ethlance/ui/page/sign_up/events.cljs:3:6: warning: namespace district.parsers is required but never used ✅ ui/src/ethlance/ui/page/sign_up/events.cljs:46:23: error: assoc-in with single key ✅ ui/src/ethlance/ui/page/sign_up/events.cljs:6:6: warning: namespace district.ui.web3-accounts.events is required but never used ✅ ui/src/ethlance/ui/page/sign_up/events.cljs:9:41: warning: #'ethlance.ui.util.component/>evt is referred but never used ✅ ui/src/ethlance/ui/page/sign_up/events.cljs:9:6: warning: namespace ethlance.ui.util.component is required but never used ✅ ui/src/ethlance/ui/page/sign_up/subscriptions.cljs:4:6: warning: namespace ethlance.ui.subscriptions is required but never used ✅ ui/src/ethlance/ui/page/sign_up/subscriptions.cljs:5:6: warning: namespace ethlance.ui.util.urls is required but never used ✅ ui/src/ethlance/ui/subscriptions.cljs:37:11: warning: Unresolved namespace ethlance.shared.utils. Are you missing a require? ✅ ui/src/ethlance/ui/util/graphql.cljs:8:57: error: get-in with single key ✅ ui/src/ethlance/ui/util/tokens.cljs:68:9: warning: Unresolved namespace clojure.walk. Are you missing a require? ✅ ui/src/ethlance/ui/util/tokens.cljs:7:6: warning: namespace re-frame.core is required but never used ✅ ui/src/ethlance/ui/util/urls.cljs:17:10: warning: Unresolved namespace clojure.string. Are you missing a require? ✅ ui/src/ethlance/ui/util/urls.cljs:3:6: warning: namespace ethlance.ui.config is required but never used ✅ ui/src/ethlance/ui/util/users.cljs:16:34: error: Unresolved symbol: ilike= ✅ ui/src/ethlance/ui/util/users.cljs:7:35: error: get-in with single key
madis
force-pushed
the
improve-code-quality
branch
from
aa3d9a9 to
9551e53
Compare
Changes: ✅ server/src/district/server/async_db.cljs:5:33: warning: #'cljs.core.async/go is referred but never used ✅ server/src/ethlance/server/core.cljs:23:57: warning: #'ethlance.shared.utils/slurp is referred but never used ✅ server/src/ethlance/server/core.cljs:42:4: warning: Unresolved namespace cljs.reader. Are you missing a require? ✅ server/src/ethlance/server/core.cljs:4:6: warning: namespace alphabase.base58 is required but never used ✅ server/src/ethlance/server/core.cljs:5:6: warning: namespace alphabase.hex is required but never used ✅ server/src/ethlance/server/db.cljs:1064:56: warning: Unresolved namespace clojure.walk. Are you missing a require? ✅ server/src/ethlance/server/db.cljs:699:5: warning: Missing else branch. ✅ server/src/ethlance/server/db.cljs:833:11: warning: unused binding job-fields ✅ server/src/ethlance/server/graphql/resolvers.cljs:1070:47: warning: unused binding args ✅ server/src/ethlance/server/graphql/resolvers.cljs:1072:38: warning: unused binding parsed-root ✅ server/src/ethlance/server/graphql/resolvers.cljs:1074:58: warning: Unresolved namespace camel-snake-kebab.core. Are you missing a require? ✅ server/src/ethlance/server/graphql/resolvers.cljs:1084:37: warning: unused binding args ✅ server/src/ethlance/server/graphql/resolvers.cljs:1086:38: warning: unused binding parsed-root ✅ server/src/ethlance/server/graphql/resolvers.cljs:1096:17: warning: unused binding limit ✅ server/src/ethlance/server/graphql/resolvers.cljs:1096:24: warning: unused binding offset ✅ server/src/ethlance/server/graphql/resolvers.cljs:1096:37: warning: unused binding args ✅ server/src/ethlance/server/graphql/resolvers.cljs:1098:38: warning: unused binding parsed-root ✅ server/src/ethlance/server/graphql/resolvers.cljs:1165:51: warning: unused binding params ✅ server/src/ethlance/server/graphql/resolvers.cljs:1198:21: warning: unused binding timestamp ✅ server/src/ethlance/server/graphql/resolvers.cljs:1240:25: warning: unused binding current-user ✅ server/src/ethlance/server/graphql/resolvers.cljs:1240:38: warning: unused binding timestamp ✅ server/src/ethlance/server/graphql/resolvers.cljs:1326:65: warning: Unresolved var: syncer/syncer ✅ server/src/ethlance/server/graphql/resolvers.cljs:1327:32: warning: Loop without recur. ✅ server/src/ethlance/server/graphql/resolvers.cljs:155:11: warning: unused binding args ✅ server/src/ethlance/server/graphql/resolvers.cljs:155:16: warning: unused binding context ✅ server/src/ethlance/server/graphql/resolvers.cljs:155:24: warning: unused binding info ✅ server/src/ethlance/server/graphql/resolvers.cljs:158:38: warning: unused binding clj-parent ✅ server/src/ethlance/server/graphql/resolvers.cljs:167:11: warning: unused binding args ✅ server/src/ethlance/server/graphql/resolvers.cljs:167:16: warning: unused binding context ✅ server/src/ethlance/server/graphql/resolvers.cljs:167:24: warning: unused binding info ✅ server/src/ethlance/server/graphql/resolvers.cljs:170:38: warning: unused binding clj-parent ✅ server/src/ethlance/server/graphql/resolvers.cljs:179:11: warning: unused binding args ✅ server/src/ethlance/server/graphql/resolvers.cljs:179:16: warning: unused binding context ✅ server/src/ethlance/server/graphql/resolvers.cljs:179:24: warning: unused binding info ✅ server/src/ethlance/server/graphql/resolvers.cljs:191:16: warning: unused binding context ✅ server/src/ethlance/server/graphql/resolvers.cljs:191:24: warning: unused binding info ✅ server/src/ethlance/server/graphql/resolvers.cljs:207:16: warning: unused binding context ✅ server/src/ethlance/server/graphql/resolvers.cljs:207:24: warning: unused binding info ✅ server/src/ethlance/server/graphql/resolvers.cljs:218:23: warning: unused binding id ✅ server/src/ethlance/server/graphql/resolvers.cljs:349:16: warning: Unused private var ethlance.server.graphql.resolvers/user-type-query ✅ server/src/ethlance/server/graphql/resolvers.cljs:434:38: warning: unused binding address-from-args ✅ server/src/ethlance/server/graphql/resolvers.cljs:448:38: warning: unused binding address-from-args ✅ server/src/ethlance/server/graphql/resolvers.cljs:465:38: warning: unused binding address-from-args ✅ server/src/ethlance/server/graphql/resolvers.cljs:479:38: warning: unused binding address-from-args ✅ server/src/ethlance/server/graphql/resolvers.cljs:493:15: warning: unused binding args ✅ server/src/ethlance/server/graphql/resolvers.cljs:493:42: warning: unused binding timestamp ✅ server/src/ethlance/server/graphql/resolvers.cljs:493:58: warning: unused binding ctx ✅ server/src/ethlance/server/graphql/resolvers.cljs:515:11: warning: unused binding args ✅ server/src/ethlance/server/graphql/resolvers.cljs:742:9: warning: unused binding args ✅ server/src/ethlance/server/graphql/resolvers.cljs:744:66: warning: unused binding root-clj ✅ server/src/ethlance/server/graphql/resolvers.cljs:760:32: warning: unused binding args ✅ server/src/ethlance/server/graphql/resolvers.cljs:766:38: warning: unused binding message-id ✅ server/src/ethlance/server/graphql/resolvers.cljs:819:19: warning: unused binding contract ✅ server/src/ethlance/server/graphql/resolvers.cljs:819:29: warning: unused binding id ✅ server/src/ethlance/server/graphql/resolvers.cljs:827:61: error: assoc-in with single key ✅ server/src/ethlance/server/graphql/resolvers.cljs:832:11: warning: unused binding args ✅ server/src/ethlance/server/graphql/resolvers.cljs:847:14: warning: unused binding id ✅ server/src/ethlance/server/graphql/resolvers.cljs:935:4: warning: unused binding parent ✅ server/src/ethlance/server/graphql/resolvers.cljs:947:14: warning: unused binding limit ✅ server/src/ethlance/server/graphql/resolvers.cljs:948:14: warning: unused binding offset ✅ server/src/ethlance/server/graphql/server.cljs:59:41: warning: unused binding req ✅ server/src/ethlance/server/syncer.cljs:119:11: warning: unused binding job-story-id ✅ server/src/ethlance/server/syncer.cljs:120:11: warning: unused binding invoicer ✅ server/src/ethlance/server/syncer.cljs:160:29: warning: unused binding dispute-resolved-event ✅ server/src/ethlance/server/syncer.cljs:186:29: warning: unused binding event ✅ server/src/ethlance/server/syncer.cljs:192:11: warning: unused binding job-story ✅ server/src/ethlance/server/syncer.cljs:212:29: warning: unused binding event ✅ server/src/ethlance/server/syncer.cljs:232:29: warning: unused binding event ✅ server/src/ethlance/server/syncer.cljs:246:9: warning: redundant do ✅ server/src/ethlance/server/syncer.cljs:261:29: warning: unused binding event ✅ server/src/ethlance/server/syncer.cljs:278:29: warning: unused binding event ✅ server/src/ethlance/server/syncer.cljs:34:5: warning: unused binding event ✅ server/src/ethlance/server/syncer.cljs:59:7: warning: Missing else branch. ✅ server/src/ethlance/server/syncer.cljs:71:61: warning: Unresolved var: ipfs/ipfs ✅ server/src/ethlance/server/syncer.cljs:85:61: error: get-in with single key ✅ server/src/ethlance/server/ui_config.cljs:18:29: warning: Unresolved namespace cljs.reader. Are you missing a require? ✅ server/src/ethlance/server/ui_config.cljs:5:6: warning: namespace district.server.async-db is required but never used ✅ server/src/ethlance/server/ui_config.cljs:6:44: warning: #'district.shared.async-helpers/<? is referred but never used ✅ server/src/ethlance/server/ui_config.cljs:6:47: warning: #'district.shared.async-helpers/safe-go is referred but never used ✅ server/src/ethlance/server/ui_config.cljs:6:6: warning: namespace district.shared.async-helpers is required but never used ✅ server/src/ethlance/server/utils.cljs:15:4: warning: Unresolved namespace cljs.reader. Are you missing a require? ✅ server/src/tests/contract/ethlance_test.cljs:150:5: warning: Only the first async test of a deftest will run ✅ server/src/tests/contract/ethlance_test.cljs:5:6: warning: duplicate require of cljs-web3-next.eth ✅ server/src/tests/graphql/generator.cljs:290:22: error: fn is called with 2 args but expects 1 ✅ server/src/tests/helpers/contract_funding.cljs:151:44: error: Expected: throwable, received: string. ✅ server/src/tests/setup.cljs:3:6: warning: namespace cljs.nodejs is required but never used ✅ shared/src/ethlance/shared/spec.cljs:60:30: error: Expected: set or nil, received: vector. ✅ shared/src/ethlance/shared/token_utils.cljs:10:24: warning: #'oops.core/ocall is referred but never used ✅ shared/src/ethlance/shared/token_utils.cljs:10:30: warning: #'oops.core/ocall+ is referred but never used ✅ shared/src/ethlance/shared/token_utils.cljs:10:42: warning: #'oops.core/oget+ is referred but never used ✅ shared/src/ethlance/shared/token_utils.cljs:10:48: warning: #'oops.core/oset! is referred but never used ✅ shared/src/ethlance/shared/token_utils.cljs:10:54: warning: #'oops.core/oapply is referred but never used ✅ shared/src/ethlance/shared/token_utils.cljs:10:61: warning: #'oops.core/oapply+ is referred but never used ✅ shared/src/ethlance/shared/utils.cljs:37:8: warning: Unresolved namespace clojure.string. Are you missing a require?
madis
force-pushed
the
improve-code-quality
branch
from
de9d31a to
2535694
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running it through and applying changes as per suggestions from cljstyle and clj-kondo