-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrated to org.jung.ant-contrib #157
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Stefan Jung <[email protected]>
Signed-off-by: Stefan Jung <[email protected]>
org.doctales.ant-contrib.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stefan-jung Instead of deleting this file, you could replace the contents with an alias
key, so that anyone looking for the old plug-in name org.doctales.ant-contrib
would be redirected to the new plug-in:
{
"alias": "org.jung.ant-contrib"
}
This feature isn't documented (yet), but you'll find examples in the registry repo, such as pdf2.json.
This approach can be useful in cases where there are previously published links to the old name in places that can't be easily updated.
Of course it's your choice whether you want the plug-ins to be found under the old name — but if you like the idea, you might want to do the same in #158 & #159, and/or any other previously renamed doctales
plug-ins.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stefan-jung Sorry I dropped the ball here earlier, but after further discussion in recent contributors calls, it turns out the decision not to document the alias function was intentional, as there are apparently unintended side effects where aliases don't work in certain cases.
For that reason, it's best to delete the outdated JSON file as you originally proposed.
Sorry for the delay and extra effort, this was a misunderstanding on my part. 🙇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@infotexture no worries, thank you so much for your efforts and good ideas.
Signed-off-by: Stefan Jung <[email protected]>
Migrated
org.doctales.ant-contrib
toorg.jung.ant-contrib
.