Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: skip objects using placeholders without source #253

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

albanbochsler
Copy link
Contributor

@albanbochsler albanbochsler commented Nov 14, 2024

Description

For example if an AliasPlugin is saved to the Clipboard it will cause an AttributeError in the alias_usage_view since the placeholder does not have a valid source.

Checklist

@fsbraun
Copy link
Member

fsbraun commented Nov 14, 2024

Nice catch! Thanks so much for the PR!

Can you add a test (maybe adding an alias plugin to the clipboard and then getting the view)?

@albanbochsler
Copy link
Contributor Author

Hi @fsbraun

I've added a usage view testcase for alias saved to clipboard.

Copy link
Member

@fsbraun fsbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@fsbraun fsbraun merged commit 3ba3433 into django-cms:master Nov 14, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants