Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pin djangokcms-link dependency to < 5 #175

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented Dec 1, 2024

Description

Djangocms-link 5 does not privides the forms, djangocms-bootstrap4 depends on. This PR pins the djangocms-link version to a compatible selection.

Fixes #174

Related resources

  • #...
  • #...

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

Copy link

codecov bot commented Dec 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.94%. Comparing base (732601d) to head (0b031bd).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #175   +/-   ##
=======================================
  Coverage   98.94%   98.94%           
=======================================
  Files          71       71           
  Lines        1229     1229           
  Branches       70       70           
=======================================
  Hits         1216     1216           
  Misses          8        8           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

djangocms_link.forms is missing in 5.0.0
1 participant