Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deposited tab #490

Merged
merged 6 commits into from
Jan 24, 2025
Merged

Add deposited tab #490

merged 6 commits into from
Jan 24, 2025
+386 −163

Conversation

obah
Copy link
Contributor

@obah obah commented Jan 22, 2025

  • Implemented deposited tab with dummy data
  • Changed tab switch to switch 2 so as to accommodate 3 tabs
  • Added mobile styles for new tab

whateverfw
whateverfw requested changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@whateverfw whateverfw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix failed CI along with all comments

frontend/src/components/dashboard/deposited/Deposited.jsx Outdated Show resolved Hide resolved
frontend/src/pages/dashboard/Dashboard.jsx Outdated Show resolved Hide resolved
frontend/src/pages/dashboard/Dashboard.jsx Outdated Show resolved Hide resolved
frontend/src/pages/dashboard/Dashboard.jsx Outdated Show resolved Hide resolved
frontend/src/pages/dashboard/dashboard.css Outdated Show resolved Hide resolved
frontend/src/pages/dashboard/Dashboard.jsx Outdated Show resolved Hide resolved
frontend/src/pages/dashboard/Dashboard.jsx Outdated Show resolved Hide resolved
@obah
Copy link
Contributor Author

obah commented Jan 23, 2025

All changes implemented. I am having issues running the project on docker and have informed @djeck1432 so currently, I can't fine tune the styling or see if anything breaks visually

@djeck1432 djeck1432 linked an issue Jan 23, 2025 that may be closed by this pull request
[Frontend] Add Deposited tab #479
Closed
@whateverfw whateverfw marked this pull request as ready for review January 23, 2025 09:39
whateverfw
whateverfw requested changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@whateverfw whateverfw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix build issues (you can verify that build works running build locally)
also you don't necessary need docker to run, you need only frontend.
You can just directly run start script and test things.

frontend/src/components/dashboard/dashboard-tab/DashboardTab.jsx Outdated Show resolved Hide resolved
frontend/src/pages/dashboard/Dashboard.jsx Outdated Show resolved Hide resolved
frontend/src/components/dashboard/dashboard-tab/dashboardTab.css Outdated Show resolved Hide resolved
@djeck1432
Copy link
Owner

@obah please sync with main branch

whateverfw
whateverfw requested changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@whateverfw whateverfw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sync with main
also build issue still isn't fixed

@obah
Copy link
Contributor Author

obah commented Jan 23, 2025

sync with main also build issue still isn't fixed

I am yet to push. Yarn start worked, thank you, so I am just fixing up the styles. I will soon be done then I will sync with main and push

@obah
Copy link
Contributor Author

obah commented Jan 23, 2025

@obah please sync with main branch

done

@obah
Copy link
Contributor Author

obah commented Jan 23, 2025

All done

whateverfw

This comment was marked as resolved.

Sign in to view

whateverfw
whateverfw approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@whateverfw whateverfw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

djeck1432
djeck1432 approved these changes Jan 24, 2025
View reviewed changes
Copy link
Owner

@djeck1432 djeck1432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@djeck1432 djeck1432 merged commit c74d54f into djeck1432:main Jan 24, 2025
7 of 8 checks passed
@obah obah deleted the feat/add-deposited-tab branch January 24, 2025 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whateverfw whateverfw whateverfw approved these changes

@djeck1432 djeck1432 djeck1432 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Frontend] Add Deposited tab
3 participants
@obah @djeck1432 @whateverfw