Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge stable #17069

Merged
merged 27 commits into from
Nov 16, 2024
Merged

Merge stable #17069

merged 27 commits into from
Nov 16, 2024

Conversation

kinke
Copy link
Contributor

@kinke kinke commented Nov 16, 2024

No description provided.

rikkimax and others added 25 commits July 2, 2024 08:34
Reverting dlang#14844, which caused such missing TypeInfos, *and* making
sure the special TypeInfo members are fully analyzed and ready for
codegen (otherwise hitting an assertion for the real-world project).
Required for 32-bit ARM, and non-Apple 64-bit ARM targets.

The only difference to `Gcc_Clang` is that anonymous and 0-length
bit-fields do contribute to the aggregate alignment.

Caught by existing proper C interop tests in
runnable_cxx/testbitfields.d on such targets. The hardcoded bad tests
in runnable/{bitfieldsposix64.c,dbitfieldsposix64.d} however now fail
after the fix, on such targets again.
* Fix bugzilla 24832 - Segfault in hex string

* Fix lack of camelcasing on stable branch
As the macos-12 image will be 'fully unsupported' starting with December 3rd:
actions/runner-images#10721
Conflicts:
	compiler/src/build.d
	compiler/src/dmd/dcast.d
	compiler/src/dmd/dtemplate.d
	compiler/src/dmd/expressionsem.d
@kinke kinke requested a review from ibuclaw as a code owner November 16, 2024 15:12
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
24337 critical Segfault when printing an int[] cast from a string literal
24431 regression dmd -vcg-ast crashes printing failed template instantiation
24599 regression [REG2.103] Wrongly elided TypeInfo emission leading to undefined symbols at link-time
24687 regression [REG2.110] Cannot cast string-imports to select overload anymore
24699 regression [REG2.108] No short-circuit evaluation of mixing template bool argument
24700 normal MsCoffObj_getsegment is really slow O(n^2)
24731 normal IFTI cannot handle integer expressions
24760 normal ICE on variadic after default argument
24764 normal ICE when -vcg-ast prints imported invariant
24790 normal -vcg-ast ICE on lowered assign exp
24812 regression [REG 2.106] Incorrect highlighting when diagnosing an empty enum declaration since #15664
24819 major Optimizer changes result of float calculations on 32-bit
24832 normal Segfault in hex string
24841 enhancement UTF-16 surrogates when used as an escape of a string should hint on error
24846 normal atomicLoad does not work for class arguments with -preview=nosharedaccess

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#17069"

…eaders

GitHub Actions upgraded the WinSDK in the latest image, and its NAN is
apparently not supported by ImportC anymore, breaking CI.
@thewilsonator
Copy link
Contributor

This is missing c58e2a7 could you include that please?

@thewilsonator
Copy link
Contributor

Thanks!

@kinke
Copy link
Contributor Author

kinke commented Nov 16, 2024

My pleasure. - auto-merge won't work, the renamed CI jobs (macos-12 => 13) need updated branch rules. I'll update them after a manual merge, already did for stable earlier.

@kinke kinke merged commit f485dbf into dlang:master Nov 16, 2024
41 checks passed
@kinke kinke deleted the merge_stable branch November 16, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants