Adding block metadata facilities into the GC package #17073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @schveiguy! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#17073" |
get the typeinfo to store, and how we get the fact that a finalizer is present or not.
schveiguy
force-pushed
the
addgcblockmeta
branch
from
0b9ffc4 to
7314c9a
Compare
thewilsonator
approved these changes
Nov 18, 2024
|
Thanks for the two commits! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These facilities will be used by GCs to record array metadata and finalizer data into blocks.
These are moved from rt.lifetime, so the GC can take over. In a future PR, the API will move to the GC itself, so a GC could use any mechanism it wishes for these.
See the master plan for the new GC: schveiguy#8
This is split into 2 commits -- one is the copy/paste of the functions as-is (no changes to the code), and the second is a modification of the code so I could combine two separate functions that were nearly identical.