Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add extra Phobos tests (publictests and betterc make targets) #17108

Closed
wants to merge 1 commit into from

Conversation

kinke
Copy link
Contributor

@kinke kinke commented Dec 7, 2024

#17107 for master, to see if #17102 fixed the regression for master.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#17108"

@kinke
Copy link
Contributor Author

kinke commented Dec 7, 2024

@dkorpel: Okay, looks like master is indeed fine again after #17102. So we either need to cherry-pick that to stable (edit: #17109), or revert the first part in stable.

@kinke
Copy link
Contributor Author

kinke commented Dec 7, 2024

Closing in favor of #17107 for stable.

@kinke kinke closed this Dec 7, 2024
@kinke kinke deleted the ci_add_extra_phobos_tests_master branch December 7, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants