Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cast(STC) from TypeTag.semantic #20931

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Conversation

dkorpel
Copy link
Contributor

@dkorpel dkorpel commented Feb 28, 2025

#20928 follow up

I couldn't easily 'fix' it, see comment. I'll ask Walter if he is interested in making const checking work in ImportC.

@dkorpel dkorpel added the Severity:Refactoring No semantic changes to code label Feb 28, 2025
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#20931"

@dkorpel dkorpel added the Feature:ImportC Pertaining to ImportC support label Feb 28, 2025
@dkorpel dkorpel merged commit 978b108 into dlang:master Feb 28, 2025
42 checks passed
@dkorpel dkorpel deleted the importc-const-stc branch February 28, 2025 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:ImportC Pertaining to ImportC support Merge:auto-merge Severity:Refactoring No semantic changes to code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants