This repository was archived by the owner on Oct 12, 2022. It is now read-only.
[rt/aaA] Add _aaNew function to initialize AA #3863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + druntime#3863" |
thewilsonator
approved these changes
Jun 30, 2022
src/rt/aaA.d
Outdated
| @@ -485,6 +485,14 @@ pure nothrow @nogc unittest | |||
| // API Implementation | |||
| //------------------------------------------------------------------------------ | |||
|
|
|||
| /// Allocate new AA implementation. | |||
dkorpel
approved these changes
Jul 3, 2022
ntrel
added a commit
to ntrel/druntime
that referenced
this pull request
Jul 5, 2022
_aaNew was added recently in dlang#3863. This is consistent with `_d_assocarrayliteralTX` returning `Impl*`. Also flesh out docs for _d_assocarrayliteralTX.
|
Oh man, this is awesome! Great idea! |
dlang-bot
pushed a commit
that referenced
this pull request
Jul 5, 2022
_aaNew was added recently in #3863. This is consistent with `_d_assocarrayliteralTX` returning `Impl*`. Also flesh out docs for _d_assocarrayliteralTX.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
druntimesupport to initialize an AA. Currently you have to add and then remove a dummy key/value pair to actually allocate the AA. This is needed if you want to give out references to the same AA before populating it.https://issues.dlang.org/show_bug.cgi?id=10535
The syntax to do this will be
new AA. I suggested that syntax and it was supported by @jacob-carlborg and @rainers here: #2504 (comment)I have the
dmdcounterpart readyto submit.dlang/dmd#14257