Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Issue 18244: std.math generic functions need to have sig constraints" #6213

Merged
merged 1 commit into from
Feb 23, 2018

Conversation

MetaLang
Copy link
Member

@MetaLang MetaLang commented Feb 23, 2018

Reverts #6040

This seemingly breaks a fair amount of user code, so we should revert it until we can figure out a less intrusive fix.

https://issues.dlang.org/show_bug.cgi?id=18287
https://issues.dlang.org/show_bug.cgi?id=18473

Not sure if this is jumping the gun, but better safe than sorry.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @MetaLang!

Bugzilla references

Auto-close Bugzilla Severity Description
18244 blocker Generic functions in std.math cannot be overloaded

Copy link
Member

@ibuclaw ibuclaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@ibuclaw
Copy link
Member

ibuclaw commented Feb 23, 2018

Will there be any follow-up action taken?

@MetaLang
Copy link
Member Author

Not sure. @quickfur submitted the fix for 18244 but I don't know if he plans to try a different fix that doesn't break code.

@quickfur
Copy link
Member

I'm too busy to work on an alternative fix right now, but the plan is to fix this one way or another somehow. Having unconstrained templates in Phobos is generally not a good idea.

@MartinNowak
Copy link
Member

Similar to what we had to do for string constraints.
15027 – rangified functions no longer work with alias this'ed strings (e.g. DirEntry)
#3770
#3774

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants