Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare to split up std.format into submodules. #7785

Closed
wants to merge 1 commit into from

Conversation

berni44
Copy link
Contributor

@berni44 berni44 commented Feb 3, 2021

The idea is, to make very small steps here. One of the main problem of splitting modules is, that ideally no other PR should be merged during the process, because it's easy to overlook some of these changes while rebasing a splitting PR. So I just moved here everything to std/format/package.d (with only a single slight change, that was needed). This can be repeated, whenever another PR is merged, without fear of any loss.

Ideally PRs #7617 and #5797 are merged before this one, so no rebasing is needed there anymore (both are already labeled with the merge label, but the tests are for unknown reasons stalled since days).

See also PR #7765 for the main idea behind this.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @berni44! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#7785"

@berni44
Copy link
Contributor Author

berni44 commented Feb 6, 2021

Meanwhile I think, we should wait with splitting until #7757 and #7617 are merged. I'm closing this temporarily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants