Added check for a negative width or height value of the rectangle.

dlemstra · Oct 15, 2023 · 00c6915 · 00c6915
1 parent c480c2b
commit 00c6915
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/src/Magick.NET/Types/MagickRectangle.cs b/src/Magick.NET/Types/MagickRectangle.cs
@@ -9,6 +9,9 @@ internal sealed partial class MagickRectangle
 {
     public MagickRectangle(int x, int y, int width, int height)
     {
+        Throw.IfNegative(nameof(width), width);
+        Throw.IfNegative(nameof(height), height);
+
         X = x;
         Y = y;
         Width = width;

diff --git a/tests/Magick.NET.Tests/MagickImageTests/TheBorderMethod.cs b/tests/Magick.NET.Tests/MagickImageTests/TheBorderMethod.cs
@@ -1,6 +1,7 @@
 // Copyright Dirk Lemstra https://github.com/dlemstra/Magick.NET.
 // Licensed under the Apache License, Version 2.0.
 
+using System;
 using ImageMagick;
 using Xunit;
 
@@ -10,6 +11,20 @@ public partial class MagickImageTests
 {
     public class TheBorderMethod
     {
+        [Fact]
+        public void ShouldThrowExceptionWhenWidthIsNegative()
+        {
+            using var image = new MagickImage("xc:red", 1, 1);
+            Assert.Throws<ArgumentException>("width", () => image.Border(-1, 1));
+        }
+
+        [Fact]
+        public void ShouldThrowExceptionWhenHeightIsNegative()
+        {
+            using var image = new MagickImage("xc:red", 1, 1);
+            Assert.Throws<ArgumentException>("height", () => image.Border(1, -1));
+        }
+
         [Fact]
         public void ShouldAddBorderOnAllSides()
         {