Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LanceDB custom destination example code #1323

Merged
merged 52 commits into from
Jun 24, 2024

Conversation

Pipboyguy
Copy link
Collaborator

Description

Showcases integration of LanceDB, an open-source vector database, as a custom destination within the dlt ecosystem. It includes a Python script that demonstrates how to set up LanceDB as a custom destination and populate the vector store with data from spotify api.

Related Issues

@Pipboyguy Pipboyguy requested review from adrianbr, rudolfix and akelad May 5, 2024 20:30
@Pipboyguy Pipboyguy self-assigned this May 5, 2024
Copy link

netlify bot commented May 5, 2024

Deploy Preview for dlt-hub-docs canceled.

Name Link
🔨 Latest commit 6655f56
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/667973f722ff6e000758f214

@Pipboyguy Pipboyguy added documentation Improvements or additions to documentation destination Issue related to new destinations labels May 5, 2024
Pipboyguy added 14 commits May 5, 2024 22:35
Signed-off-by: Marcel Coetzee <[email protected]>
Signed-off-by: Marcel Coetzee <[email protected]>
Signed-off-by: Marcel Coetzee <[email protected]>
Signed-off-by: Marcel Coetzee <[email protected]>
Signed-off-by: Marcel Coetzee <[email protected]>
Signed-off-by: Marcel Coetzee <[email protected]>
Signed-off-by: Marcel Coetzee <[email protected]>
Signed-off-by: Marcel Coetzee <[email protected]>
Signed-off-by: Marcel Coetzee <[email protected]>
@sh-rp
Copy link
Collaborator

sh-rp commented May 8, 2024

It's a pretty cool example! But why are we not using our rest client? This will make the code much shorter and also showcase some of our other features. And we need to be able to run this on CI, so we need to have somebodies spotify login, maybe a free account would do for this?

Signed-off-by: Marcel Coetzee <[email protected]>
@Pipboyguy Pipboyguy requested a review from sh-rp May 14, 2024 22:56
rudolfix
rudolfix previously approved these changes Jun 4, 2024
Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is so good! thx @Pipboyguy

@rudolfix
Copy link
Collaborator

rudolfix commented Jun 5, 2024

@rahuljo if you could help me with this:

  1. set up cohere account
  2. add the secret (see the code for the key) to google vault (ping me if you need help)
  3. rerun the docs tests (that is failing)
    and then we merge it!

@AstrakhantsevaAA AstrakhantsevaAA self-assigned this Jun 21, 2024
@sh-rp sh-rp merged commit 6b83cee into devel Jun 24, 2024
47 of 49 checks passed
@sh-rp sh-rp deleted the 1322-lancedb-usage-example-docs branch June 24, 2024 13:38
@sh-rp sh-rp restored the 1322-lancedb-usage-example-docs branch June 24, 2024 13:38
@sh-rp sh-rp deleted the 1322-lancedb-usage-example-docs branch June 24, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
destination Issue related to new destinations documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

LanceDB Usage Example
5 participants