-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1356 implements OAuth2 Client Credentials Flow #1357
Conversation
d68194c
to
a3b9a8b
Compare
✅ Deploy Preview for dlt-hub-docs canceled.
|
Questions:
Thank you! |
2cd8d72
to
5f4b8ec
Compare
…ith token refresh
…s Zoom implementation, that should go to the docs
…rom constructor since this is obtained by the class
cbeb3f2
to
755a680
Compare
for the record: one user in slack reported that he used this OAuth2 implementation successfully for Hivebrite |
Hey @willi-mueller, thanks again for the PR. Looks good in general. I'll help you with the tests, let me know if it's ok if I push to your branch. |
Yes, please go ahead and refactor and add tests, I'll learn from that <3 |
…d client_id & client_secret
@willi-mueller the CI is failing tests/sources/helpers/rest_client/test_client.py::TestRESTClient::test_oauth2_client_credentials_flow_wrong_client_id |
Co-authored-by: Anton Burnashev <[email protected]>
Remove duplicated import
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
Wonderful, thank you for the thorough checks and coaching. Could you please merge the PR? I am not authorized by the branch protection rule. |
Description
This PR implements OAuth2 Client Credentials Flow with access token refresh for server-to-server authorization.
Related Issues
Additional Context
Example usage: