Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support partitioning hints for athena iceberg #1403

Merged
merged 6 commits into from
May 27, 2024
Merged

Conversation

steinitzu
Copy link
Collaborator

@steinitzu steinitzu commented May 23, 2024

Description

Adds athena_adapter to add partitioning hints in athena. Generates PARTITIONED BY clause on iceberg tables.

The adapter generates a table hint: x-athena-partition.
This is a dict in form of {<column_name>: <template_string>}
E.g. {"department": "{column_name}", "date_hired": "year({column_name})"}

Using format strings so we can generate transform (bucket(...), year(...), etc) strings and inject the escaped column name later in the loader.

Related Issues

Implements partially #555 -> Iceberg support

Copy link

netlify bot commented May 23, 2024

Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit 5f39262
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/6650ad0588f2810008caf99b
😎 Deploy Preview https://deploy-preview-1403--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@steinitzu steinitzu force-pushed the athena-partitions branch from 93c0f7a to 5f39262 Compare May 24, 2024 15:06
Copy link

netlify bot commented May 24, 2024

Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit 593ef02
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/6654b4a005349200089ca101
😎 Deploy Preview https://deploy-preview-1403--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@steinitzu steinitzu requested review from rudolfix and sh-rp May 24, 2024 16:41
@steinitzu steinitzu marked this pull request as ready for review May 24, 2024 16:41
Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code and docs: LGTM!
I think we can reconfigure tests, see my review

@rudolfix rudolfix merged commit 03f82ca into devel May 27, 2024
47 of 50 checks passed
@rudolfix rudolfix deleted the athena-partitions branch May 27, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants