Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: fix credentials link (add slash) #2162

Merged
merged 1 commit into from
Dec 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dlt/cli/deploy_command_helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ def _display_missing_secret_info(self) -> None:
" available configuration ie. secrets.toml file. Please run the deploy command from"
" the same working directory you ran your pipeline script. If you pass the"
" credentials in code we will not be able to display them here. See"
" https://dlthub.com/docs/general-usage/credentials"
" https://dlthub.com/docs/general-usage/credentials/"
)

def _lookup_secret_value(self, trace: LookupTrace) -> Any:
Expand Down
2 changes: 1 addition & 1 deletion dlt/common/configuration/exceptions.py
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ def __str__(self) -> str:
" run your script from some other folder, secrets/configs will not be found\n"
)
msg += (
"Please refer to https://dlthub.com/docs/general-usage/credentials for more"
"Please refer to https://dlthub.com/docs/general-usage/credentials/ for more"
" information\n"
)
return msg
Expand Down
4 changes: 2 additions & 2 deletions dlt/extract/decorators.py
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@ def source(
>>> list(chess("magnuscarlsen"))

Here `username` is a required, explicit python argument, `chess_url` is a required argument, that if not explicitly passed will be taken from configuration ie. `config.toml`, `api_secret` is a required argument, that if not explicitly passed will be taken from dlt secrets ie. `secrets.toml`.
See https://dlthub.com/docs/general-usage/credentials for details.
See https://dlthub.com/docs/general-usage/credentials/ for details.

Args:
func: A function that returns a dlt resource or a list of those or a list of any data items that can be loaded by `dlt`.
Expand Down Expand Up @@ -564,7 +564,7 @@ def resource(
>>> list(user_games("magnuscarlsen"))

Here `username` is a required, explicit python argument, `chess_url` is a required argument, that if not explicitly passed will be taken from configuration ie. `config.toml`, `api_secret` is a required argument, that if not explicitly passed will be taken from dlt secrets ie. `secrets.toml`.
See https://dlthub.com/docs/general-usage/credentials for details.
See https://dlthub.com/docs/general-usage/credentials/ for details.
Note that if decorated function is an inner function, passing of the credentials will be disabled.

Args:
Expand Down
2 changes: 1 addition & 1 deletion docs/website/docs/general-usage/credentials/setup.md
Original file line number Diff line number Diff line change
Expand Up @@ -665,7 +665,7 @@ dlt.common.configuration.exceptions.ConfigFieldMissingException: Following field
In secrets.toml key destination.postgres.credentials.password was not found.
In secrets.toml key destination.credentials.password was not found.
In secrets.toml key credentials.password was not found.
Please refer to https://dlthub.com/docs/general-usage/credentials for more information
Please refer to https://dlthub.com/docs/general-usage/credentials/ for more information
```

It tells you exactly which paths `dlt` looked at, via which config providers and in which order.
Expand Down
2 changes: 1 addition & 1 deletion docs/website/docs/walkthroughs/run-a-pipeline.md
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ dlt.common.configuration.exceptions.ConfigFieldMissingException: Following field
In secrets.toml key destination.postgres.credentials.password was not found.
In secrets.toml key destination.credentials.password was not found.
In secrets.toml key credentials.password was not found.
Please refer to https://dlthub.com/docs/general-usage/credentials for more information
Please refer to https://dlthub.com/docs/general-usage/credentials/ for more information
```

What does this exception tell you?
Expand Down
Loading