Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pipdeptree version to remove dependency on pip #2205

Conversation

jonbiemond
Copy link

Description

Increase the pipdeptree requirement version to be ">=2.23.2".
This release of pipdeptree removes all references to pip.
tox-dev/pipdeptree#402
The deploy command, which uses pipdeptree, may now be used in environments without pip.

Related Issues

Fixes #2203

Copy link

netlify bot commented Jan 12, 2025

Deploy Preview for dlt-hub-docs canceled.

Name Link
🔨 Latest commit 83e93f7
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/67843936b078e10008194930

@jonbiemond jonbiemond force-pushed the fix/2203-bump-pipdeptree-dependency branch from 7986565 to 5e87657 Compare January 12, 2025 12:07
@rudolfix
Copy link
Collaborator

@jonbiemond thanks for the PR! I assume you tried to upgrade pipdeptree and the deploy command is still working? There were quite significant changes in the internal object model in the past. That's why our version is locked.

In your PR, the lockfile is outdated. Please try to:

  1. merge the current devel. We just added 3.13 support so actual lockfile changes. This will avoid merge conflict.
  2. update the lock: poetry lock --no-updates (do make dev before to create dev env).

@rudolfix rudolfix self-requested a review January 12, 2025 15:49
Increase the `pipdeptree` requirement version
to be ">=2.23.2".
This release of `pipdeptree` removes all
references to `pip`.
tox-dev/pipdeptree#402
The deploy command, which uses `pipdeptree`,
may now be used in environments without `pip`.

Fixes dlt-hub#2203
@jonbiemond jonbiemond force-pushed the fix/2203-bump-pipdeptree-dependency branch from 5e87657 to 83e93f7 Compare January 12, 2025 21:50
@jonbiemond
Copy link
Author

@rudolfix Thanks for the review!

  • ✅ Place changes on top of devel
  • ✅ Update poetry.lock
  • ✅ Confirm no new tests failing
  • ‼️ Manually run deploy command with the latest pipdeptree

Unfortunately, updating pipdeptree introduces breaking changes.

@jonbiemond jonbiemond closed this Jan 13, 2025
@jonbiemond jonbiemond deleted the fix/2203-bump-pipdeptree-dependency branch January 13, 2025 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploy command fails even with extras installed
2 participants