-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Declare pip dependency for cli extras #2207
Declare pip dependency for cli extras #2207
Conversation
✅ Deploy Preview for dlt-hub-docs canceled.
|
674ca09
to
496dfff
Compare
pip's versioning scheme is |
496dfff
to
116a4d5
Compare
Hey @jonbiemond, thank you for the fix and sorry for the delayed response. Could you please merge or rebase the dev branch and regenerate |
The `pipdeptree` package includes references to `pip` but does not explicitly require it. To ensure `pip` is installed in the environment, declare it as a dependency.
116a4d5
to
e73037a
Compare
Some tests require pip.
Hi @burnash, no worries! I've rebased and regenerated the lock file. There are also two tests failing in CI. Now that pip is explicitly declared as an optional dependency, I've added a commit to include pip in the dev dependencies as well. This should resolve the failing tests. Alternatively all dependencies could be installed in CI with the |
lgtm, I'll merge it @burnash |
The
pipdeptree
package includes references topip
but does not explicitly require it.To ensure
pip
is installed in a users environment, include it as a dependency.Fixes #2203