Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update branch naming guide in contributing doc to add a "keep" prefix #2242

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

sh-rp
Copy link
Collaborator

@sh-rp sh-rp commented Jan 27, 2025

Description

Some branches we want to keep around for reference or for working on later but close the pr. For this we add a keep prefix.

Copy link

netlify bot commented Jan 27, 2025

Deploy Preview for dlt-hub-docs canceled.

Name Link
🔨 Latest commit a8618f4
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/6797aadd6b0d7400080727f7

@sh-rp sh-rp marked this pull request as ready for review January 27, 2025 17:24
@sh-rp sh-rp requested a review from burnash January 27, 2025 17:24
Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Also @burnash should see it before merging

@sh-rp sh-rp merged commit 0be70f9 into devel Jan 28, 2025
49 checks passed
@sh-rp sh-rp deleted the docs/update_branch_naming_guide branch January 28, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants