feat: show confirm-cancel prompt for comments and approvals #518
+78
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sideshowbarker
force-pushed
the
comment-confirm-cancel
branch
from
991c16a to
1731d8c
Compare
|
OK, thanks! — made the fixes suggested, and pushed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change causes gh-dash to show a “Really cancel comment? (Press Ctrl+c/esc again to cancel)” confirm-quit prompt when the user is typing a comment or approval and they press Ctrl+c/esc — similar to the existing confirm-cancel prompt that gh-dash shows when the user has hit q/esc to exit from gh-dash itself.
How did you test this change?
I ran
make test(go test -v ./...), to ensure this change didn’t regress any existing tests.Otherwise, I just tested by manually by building this branch and then in PR dashboard and issue dashboard, using the
cshortcut to open the comment-entry UI, and in the PR dashboard, using thevshortcut to open the approval-entry UI.Images/Videos
Comment-entry UI:
Approval-entry UI: