Suppressing warnings generated by 5 GraphBolt tests. #6726

drivanov · 2023-12-12T00:16:06Z

Description

Elimination of the following warnings:

tests/python/pytorch/graphbolt/test_base.py: 2 warnings
tests/python/pytorch/graphbolt/test_feature_fetcher.py: 4 warnings
tests/python/pytorch/graphbolt/test_item_sampler.py: 9 warnings
tests/python/pytorch/graphbolt/test_base.py::test_CopyTo 1 warning
  /usr/local/lib/python3.10/dist-packages/dgl/graphbolt/item_sampler.py:45: DGLWarning: Failed to map item list to `MiniBatch` as the names of items are not provided. Please provide a customized `MiniBatcher`. The item list is returned as is.
    dgl_warning(

Checklist

Please feel free to remove inapplicable items for your PR.

I've leverage the tools to beautify the python and c++ code.
The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
Code is well-documented
To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

dgl-bot · 2023-12-12T00:16:32Z

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

@dgl-bot

dgl-bot · 2023-12-12T00:16:44Z

Commit ID: e892132

Build ID: 1

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

dgl-bot · 2023-12-12T17:39:30Z

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

@dgl-bot

dgl-bot · 2023-12-12T17:39:42Z

Commit ID: 9dd074308cc7591ff80ca2fbbc541ba3121b420b

Build ID: 2

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

dgl-bot · 2023-12-13T00:41:29Z

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

@dgl-bot

dgl-bot · 2023-12-13T00:41:41Z

Commit ID: 8ceab20

Build ID: 3

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

dgl-bot · 2023-12-13T17:01:17Z

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

@dgl-bot

dgl-bot · 2023-12-13T17:01:30Z

Commit ID: f012766

Build ID: 4

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

dgl-bot · 2023-12-20T22:46:11Z

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

@dgl-bot

dgl-bot · 2023-12-20T22:46:24Z

Commit ID: 05f2b32

Build ID: 5

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

dgl-bot · 2023-12-30T20:56:25Z

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

@dgl-bot

dgl-bot · 2023-12-30T20:56:36Z

Commit ID: 5b6702b

Build ID: 6

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

tests/python/pytorch/graphbolt/test_base.py

dgl-bot · 2024-01-02T17:52:53Z

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

@dgl-bot

dgl-bot · 2024-01-02T17:53:05Z

Commit ID: 7602dbd

Build ID: 7

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

dgl-bot · 2024-01-04T19:33:34Z

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

@dgl-bot

dgl-bot · 2024-01-04T19:33:46Z

Commit ID: 8b484cc

Build ID: 8

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

dgl-bot · 2024-01-05T17:58:02Z

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

@dgl-bot

dgl-bot · 2024-01-05T17:58:14Z

Commit ID: 1c598d5

Build ID: 9

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

dgl-bot · 2024-01-08T16:53:44Z

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

@dgl-bot

dgl-bot · 2024-01-17T01:24:28Z

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

@dgl-bot

dgl-bot · 2024-01-17T01:24:39Z

Commit ID: 6939e7a

Build ID: 13

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

dgl-bot · 2024-01-18T20:31:28Z

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

@dgl-bot

dgl-bot · 2024-01-18T20:31:40Z

Commit ID: dfc3d8a

Build ID: 14

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

dgl-bot · 2024-01-19T19:54:45Z

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

@dgl-bot

dgl-bot · 2024-01-19T19:54:57Z

Commit ID: 5072368

Build ID: 15

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

dgl-bot · 2024-01-22T20:12:43Z

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

@dgl-bot

dgl-bot · 2024-01-22T20:12:55Z

Commit ID: 1debe16

Build ID: 16

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

dgl-bot · 2024-01-29T18:34:43Z

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

@dgl-bot

dgl-bot · 2024-01-29T18:34:55Z

Commit ID: 4579428

Build ID: 17

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

frozenbugs · 2024-01-31T08:54:47Z

@dgl-bot

dgl-bot · 2024-01-31T09:39:10Z

Commit ID: 7daf8cecb298f730bb76d362de9f526328dec4f1

Build ID: 18

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

frozenbugs · 2024-01-31T09:41:30Z

tests/python/pytorch/graphbolt/test_base.py

@@ -13,17 +14,20 @@

 @unittest.skipIf(F._default_context_str == "cpu", "CopyTo needs GPU to test")
 def test_CopyTo():
-    item_sampler = gb.ItemSampler(gb.ItemSet(torch.randn(20)), 4)


Actually the original code is not a suggested way to use ItemSampler, to address the warning related to minibatch.

tests/python/pytorch/graphbolt/test_base.py

dgl-bot · 2024-01-31T23:16:24Z

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

@dgl-bot

dgl-bot · 2024-01-31T23:16:36Z

Commit ID: ab76398

Build ID: 19

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

dgl-bot · 2024-01-31T23:33:54Z

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

@dgl-bot

dgl-bot · 2024-01-31T23:34:06Z

Commit ID: 0ce8253

Build ID: 20

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

dgl-bot · 2024-01-31T23:37:23Z

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

@dgl-bot

dgl-bot · 2024-01-31T23:37:35Z

Commit ID: f4cbd50

Build ID: 21

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

Rhett-Ying · 2024-02-01T02:55:25Z

@drivanov I made a fix to eliminate the warnings in #7054

Suppressing warnings generated by 5 GraphBolt tests.

e892132

Fixing lint problems.

6a7b7db

Merge branch 'master' into graphbolt_warn

8ceab20

Merge branch 'master' into graphbolt_warn

f012766

Merge branch 'master' into graphbolt_warn

05f2b32

Merge branch 'master' into graphbolt_warn

5b6702b

Rhett-Ying reviewed Jan 2, 2024

View reviewed changes

tests/python/pytorch/graphbolt/test_base.py Outdated Show resolved Hide resolved

Merge branch 'master' into graphbolt_warn

7602dbd

Merge branch 'master' into graphbolt_warn

8b484cc

Merge branch 'master' into graphbolt_warn

1c598d5

Merge branch 'master' into graphbolt_warn

f80601b

Merge branch 'master' into graphbolt_warn

dfc3d8a

Merge branch 'master' into graphbolt_warn

5072368

Merge branch 'master' into graphbolt_warn

1debe16

Merge branch 'master' into graphbolt_warn

4579428

frozenbugs reviewed Jan 31, 2024

View reviewed changes

tests/python/pytorch/graphbolt/test_base.py Outdated Show resolved Hide resolved

Merge branch 'dmlc:master' into graphbolt_warn

ab76398

Change suggested by @frozenbugs

0ce8253

Fixing Lint problems

f4cbd50

Rhett-Ying mentioned this pull request Feb 1, 2024

[GraphBolt] fix testcases on warning messages #7054

Merged

8 tasks

Rhett-Ying closed this Feb 1, 2024

Suppressing warnings generated by 5 GraphBolt tests. #6726

Suppressing warnings generated by 5 GraphBolt tests. #6726

Conversation

drivanov commented Dec 12, 2023

Description

Checklist

dgl-bot commented Dec 12, 2023

dgl-bot commented Dec 12, 2023

dgl-bot commented Dec 12, 2023

dgl-bot commented Dec 12, 2023

dgl-bot commented Dec 13, 2023

dgl-bot commented Dec 13, 2023

dgl-bot commented Dec 13, 2023

dgl-bot commented Dec 13, 2023

dgl-bot commented Dec 20, 2023

dgl-bot commented Dec 20, 2023

dgl-bot commented Dec 30, 2023

dgl-bot commented Dec 30, 2023

dgl-bot commented Jan 2, 2024

dgl-bot commented Jan 2, 2024

dgl-bot commented Jan 4, 2024

dgl-bot commented Jan 4, 2024

dgl-bot commented Jan 5, 2024

dgl-bot commented Jan 5, 2024

dgl-bot commented Jan 8, 2024

dgl-bot commented Jan 17, 2024

dgl-bot commented Jan 17, 2024

dgl-bot commented Jan 18, 2024

dgl-bot commented Jan 18, 2024

dgl-bot commented Jan 19, 2024

dgl-bot commented Jan 19, 2024

dgl-bot commented Jan 22, 2024

dgl-bot commented Jan 22, 2024

dgl-bot commented Jan 29, 2024

dgl-bot commented Jan 29, 2024

frozenbugs commented Jan 31, 2024

dgl-bot commented Jan 31, 2024

frozenbugs Jan 31, 2024

Choose a reason for hiding this comment

dgl-bot commented Jan 31, 2024

dgl-bot commented Jan 31, 2024

dgl-bot commented Jan 31, 2024

dgl-bot commented Jan 31, 2024

dgl-bot commented Jan 31, 2024

dgl-bot commented Jan 31, 2024

Rhett-Ying commented Feb 1, 2024