Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphBolt][CUDA] Refactor IndexSelectCSC and add output_size argument #6927

Merged
merged 9 commits into from
Jan 12, 2024

Conversation

mfbalin
Copy link
Collaborator

@mfbalin mfbalin commented Jan 9, 2024

Description

Refactoring the implementation so that if the indptr tensor is already sliced, then we don't need to slice it again and again when we call IndexSelectCSC. Also adding output_size argument so that synchronization can be eliminated if it is available.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@mfbalin mfbalin changed the title [GraphBolt][CUDA] Refactor IndexSelectCSC and add output_size argument [GraphBolt][CUDA] Refactor IndexSelectCSC and add output_size argument Jan 9, 2024
@dgl-bot
Copy link
Collaborator

dgl-bot commented Jan 9, 2024

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jan 10, 2024

Commit ID: 86057f4

Build ID: 1

Status: ❌ CI test failed in Stage [Torch GPU Unit test].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jan 10, 2024

Commit ID: bfb10a1

Build ID: 2

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jan 10, 2024

Commit ID: bfb10a1

Build ID: 3

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jan 12, 2024

Commit ID: 850ba5a

Build ID: 4

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jan 12, 2024

Commit ID: d63b45e

Build ID: 5

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@mfbalin mfbalin force-pushed the gb_cuda_refactor_index_select_csc branch from a1c3948 to f2e18ac Compare January 12, 2024 09:40
@dgl-bot
Copy link
Collaborator

dgl-bot commented Jan 12, 2024

Commit ID: a1c3948

Build ID: 6

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jan 12, 2024

Commit ID: f2e18ac

Build ID: 7

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jan 12, 2024

Commit ID: 0b36326

Build ID: 8

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jan 12, 2024

Commit ID: a76c39f

Build ID: 9

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jan 12, 2024

Commit ID: 05b2c3b

Build ID: 10

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@mfbalin mfbalin merged commit 0f3bfd7 into dmlc:master Jan 12, 2024
2 checks passed
@mfbalin mfbalin deleted the gb_cuda_refactor_index_select_csc branch January 12, 2024 11:10
DominikaJedynak pushed a commit to DominikaJedynak/dgl that referenced this pull request Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants