-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GraphBolt][CUDA] Refactor IndexSelectCSC
and add output_size
argument
#6927
Merged
mfbalin
merged 9 commits into
dmlc:master
from
mfbalin:gb_cuda_refactor_index_select_csc
Jan 12, 2024
Merged
[GraphBolt][CUDA] Refactor IndexSelectCSC
and add output_size
argument
#6927
mfbalin
merged 9 commits into
dmlc:master
from
mfbalin:gb_cuda_refactor_index_select_csc
Jan 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfbalin
changed the title
[GraphBolt][CUDA] Refactor IndexSelectCSC and add output_size argument
[GraphBolt][CUDA] Refactor Jan 9, 2024
IndexSelectCSC
and add output_size
argument
To trigger regression tests:
|
Rhett-Ying
approved these changes
Jan 12, 2024
mfbalin
force-pushed
the
gb_cuda_refactor_index_select_csc
branch
from
January 12, 2024 09:40
a1c3948
to
f2e18ac
Compare
DominikaJedynak
pushed a commit
to DominikaJedynak/dgl
that referenced
this pull request
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactoring the implementation so that if the
indptr
tensor is already sliced, then we don't need to slice it again and again when we call IndexSelectCSC. Also adding output_size argument so that synchronization can be eliminated if it is available.Checklist
Please feel free to remove inapplicable items for your PR.
Changes