Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphBolt] Add check about whether edge IDs are saved when edge feature is stored. #6948

Merged
merged 3 commits into from
Jan 16, 2024

Conversation

yxy235
Copy link
Collaborator

@yxy235 yxy235 commented Jan 15, 2024

Description

If edge IDs are not saved when edge feature is stored, make warnings to user.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

Sorry, something went wrong.

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jan 15, 2024

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jan 15, 2024

Commit ID: 16da91d

Build ID: 1

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@yxy235 yxy235 force-pushed the add_check_eids_efeat branch from 16da91d to 3444626 Compare January 15, 2024 07:30
@dgl-bot
Copy link
Collaborator

dgl-bot commented Jan 15, 2024

Commit ID: 3444626

Build ID: 2

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@yxy235 yxy235 force-pushed the add_check_eids_efeat branch from 3444626 to e6a1971 Compare January 16, 2024 03:29
@dgl-bot
Copy link
Collaborator

dgl-bot commented Jan 16, 2024

Commit ID: e6a1971

Build ID: 3

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jan 16, 2024

Commit ID: 44855a8

Build ID: 4

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@yxy235 yxy235 requested a review from frozenbugs January 16, 2024 06:06
@dgl-bot
Copy link
Collaborator

dgl-bot commented Jan 16, 2024

Commit ID: 6f6eeef

Build ID: 5

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@yxy235 yxy235 merged commit de1eedc into dmlc:master Jan 16, 2024
1 check passed
@yxy235 yxy235 deleted the add_check_eids_efeat branch January 17, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants