Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphBolt] Add check to NegativeSampler. #6976

Merged
merged 3 commits into from
Jan 22, 2024

Conversation

yxy235
Copy link
Collaborator

@yxy235 yxy235 commented Jan 18, 2024

Description

Add check to NegativeSampler to select which function to use. This check will be cleaned up once refactor is done.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@yxy235 yxy235 requested a review from frozenbugs January 18, 2024 10:11
@dgl-bot
Copy link
Collaborator

dgl-bot commented Jan 18, 2024

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jan 18, 2024

Commit ID: 631f390

Build ID: 1

Status: ❌ CI test failed in Stage [Lint Check].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jan 18, 2024

Commit ID: 03029b1

Build ID: 2

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@frozenbugs frozenbugs linked an issue Jan 22, 2024 that may be closed by this pull request
@frozenbugs frozenbugs merged commit 351c860 into dmlc:master Jan 22, 2024
2 checks passed
@yxy235 yxy235 linked an issue Jan 22, 2024 that may be closed by this pull request
@yxy235 yxy235 deleted the add_para_use_seeds branch February 6, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GraphBolt] Refactor Negative sampler
3 participants