-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jvm-packages] Update javadoc plugin. #10978
Conversation
@wbo4958 Could you please help take a look into the errors when you are available? I'm not sure how to resolve it during mvn test run in short of rewriting labeled point:
|
I'm really not a fan of updating the plugin or dependency frequently. that could bring more work for us since the new release of the plugin probably has some issue which may cause compiling and testing fail. |
@wbo4958 Should we disable the dependabot entirely? It was added because some users use security scanners that scans CVEs in the dependencies. |
I will look into the fix. |
Hi @hcho3, I'm wondering if the javadoc compiling is working before? I just tried it without updating the version of maven-javadoc-plugin and it didn't work for the latest master HEAD |
The problem here is the javadoc couldn't find the scala class (LabeledPoint) |
To be honest, I didn't find any solution for this issue. I'm wondering if we need to move LabeledPoint from scala to java to fix this issue. |
Yeah, I thought about that as well, was thinking if you know some magic for a simpler fix |
Yes, Javadoc hasn't been able to generate document for LabeledPoint for a while. The status quo is to ignore the warning and get a Javadoc without any documentation for LabeledPoint. |
Hi @hcho3, What's the final decision on this issue? should we move the LabeledPoint to java or just ignore the warning? |
We can probably ignore the warning for now. |
supersede #10976 .