Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jvm-packages] Update javadoc plugin. #10978

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Conversation

trivialfis
Copy link
Member

supersede #10976 .

@trivialfis
Copy link
Member Author

trivialfis commented Nov 3, 2024

@wbo4958 Could you please help take a look into the errors when you are available? I'm not sure how to resolve it during mvn test run in short of rewriting labeled point:

[WARNING] Javadoc Warnings
[WARNING] /workspace/jvm-packages/xgboost4j/src/main/java/ml/dmlc/xgboost4j/java/DMatrix.java:20: error: cannot find symbol
[WARNING] import ml.dmlc.xgboost4j.LabeledPoint;
[WARNING] ^
[WARNING] symbol:   class LabeledPoint
[WARNING] location: package ml.dmlc.xgboost4j
[WARNING] /workspace/jvm-packages/xgboost4j/src/main/java/ml/dmlc/xgboost4j/java/DMatrix.java:38: error: cannot find symbol
[WARNING] public DMatrix(Iterator<LabeledPoint> iter, String cacheInfo) throws XGBoostError {
[WARNING] ^
[WARNING] symbol:   class LabeledPoint

@wbo4958
Copy link
Contributor

wbo4958 commented Nov 4, 2024

I'm really not a fan of updating the plugin or dependency frequently. that could bring more work for us since the new release of the plugin probably has some issue which may cause compiling and testing fail.

@hcho3
Copy link
Collaborator

hcho3 commented Nov 4, 2024

@wbo4958 Should we disable the dependabot entirely? It was added because some users use security scanners that scans CVEs in the dependencies.

@trivialfis
Copy link
Member Author

I will look into the fix.

@wbo4958
Copy link
Contributor

wbo4958 commented Nov 5, 2024

Hi @hcho3, I'm wondering if the javadoc compiling is working before? I just tried it without updating the version of maven-javadoc-plugin and it didn't work for the latest master HEAD

@wbo4958
Copy link
Contributor

wbo4958 commented Nov 5, 2024

The problem here is the javadoc couldn't find the scala class (LabeledPoint)

@wbo4958
Copy link
Contributor

wbo4958 commented Nov 5, 2024

To be honest, I didn't find any solution for this issue. I'm wondering if we need to move LabeledPoint from scala to java to fix this issue.

@trivialfis
Copy link
Member Author

Yeah, I thought about that as well, was thinking if you know some magic for a simpler fix

@hcho3
Copy link
Collaborator

hcho3 commented Nov 5, 2024

Yes, Javadoc hasn't been able to generate document for LabeledPoint for a while. The status quo is to ignore the warning and get a Javadoc without any documentation for LabeledPoint.

@wbo4958
Copy link
Contributor

wbo4958 commented Nov 6, 2024

Hi @hcho3, What's the final decision on this issue? should we move the LabeledPoint to java or just ignore the warning?

@hcho3
Copy link
Collaborator

hcho3 commented Nov 6, 2024

We can probably ignore the warning for now.

@hcho3 hcho3 merged commit 05ea33e into dmlc:master Nov 8, 2024
27 of 30 checks passed
@trivialfis trivialfis deleted the jvm-javadoc branch November 8, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants