Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move feature weight to skl parameters. #9506

Merged
merged 3 commits into from
Feb 24, 2025

Conversation

trivialfis
Copy link
Member

Close #8087 .

Revert "Move feature weight to skl parameters."

This reverts commit e45e3b3.

Revert "Revert "Move feature weight to skl parameters.""

This reverts commit 1749338.
@trivialfis trivialfis changed the title [WIP] Move feature weight to skl parameters. Move feature weight to skl parameters. Feb 20, 2025
@trivialfis trivialfis marked this pull request as ready for review February 20, 2025 17:01
@trivialfis trivialfis requested a review from hcho3 February 20, 2025 17:17
@trivialfis trivialfis mentioned this pull request Feb 20, 2025
9 tasks
@trivialfis
Copy link
Member Author

@hcho3 Please help take a look when you are available. Would be great if we could get this into 3.0 as well.

@trivialfis
Copy link
Member Author

cc @rongou

@trivialfis trivialfis merged commit 73e0df6 into dmlc:master Feb 24, 2025
59 checks passed
@trivialfis trivialfis deleted the move-feature-weight branch February 24, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[py-skl] Move feature_weights to constructor.
2 participants