Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python six compatibility layer, as requested #10

Merged
merged 4 commits into from
Jan 12, 2017
Merged

Python six compatibility layer, as requested #10

merged 4 commits into from
Jan 12, 2017

Conversation

KM4YRI
Copy link
Contributor

@KM4YRI KM4YRI commented Jan 12, 2017

As requested per #9.

Regarding other python 3 paradigms and backporting to python 2. enums are possible using 'enum34', a backport library to add enum syntax to python 2. I didn't want to add this without discussing, it's your call, but personally it's probably not worth the hassle of yet another dependency. I didn't see a clean way to get 'yield from' syntax in python 2, but what's there now works for both. All in all it seems to be in pretty good shape. I've got my build system setup to test both python 2.7 and 3.5 and it seems to be working with both.

@dnet
Copy link
Owner

dnet commented Jan 12, 2017

Looks great, thanks! I'll merge it and then add some checks to Travis to ensure CI checks for 2+3 compatibility as well for future commits.

I completely agree with you regarding enums and yield from, I just used them in the python3 branch to try these new Python 3 features. I like playing with new features on projects such as this, since it's already something useful, but still small enough to make such changes in a short time. 😃

@dnet dnet merged commit 5d3b11a into dnet:master Jan 12, 2017
dnet added a commit that referenced this pull request Jan 12, 2017
@dnet
Copy link
Owner

dnet commented Jan 12, 2017

The test suite held some surprises for me, but now everything works according to Travis as well, so I released 0.3 on GitHub and PyPI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants