Merge latest from upstream #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When parsing the `HtmlAttributesAsString` property, the keys and values accumulate, so that when there are multiple key/value pairs, the keys and values are duplicated. For example, `HtmlAttributesAsString="defer=true,async=true"` yields the following:
defer=true
deferasync=truetrue
Some sites force a "/" to be at the end of every URL Shazwazza#110
Fix bug with multiple values in HtmlAttributes
sorry, didn't mean to commit that change :(
…ath/FileInfo/GetExtension, missing using statements, returns 404 when processing cannot be done instead of throwing, trims file paths, adds propery logging to test site
Fix to EnableDebugVersionString reading incorrect config key
Fix to EnableDebugVersionString reading incorrect config key
Resolve issue Shazwazza#134 Require a Web.config app setting key="ClientDependencyHTML4" value="true" in order to output type="text/javascript"
Setting explicit version for dotless dependency
So we can easily extend the providers overriding the functions that return this class. The previous fix Serializing and deserializing using json doesn't work anymore.
Make the constructor public
# Conflicts: # ClientDependency.Core/CompositeFiles/Providers/BaseCompositeFileProcessingProvider.cs
valadas
requested changes
Aug 11, 2021
# Conflicts: # ClientDependency.Core/CompositeFiles/CompositeDependencyHandler.cs # ClientDependency.Core/CompositeFiles/Providers/BaseCompositeFileProcessingProvider.cs # ClientDependency.Core/CompositeFiles/Providers/CompositeFileProcessingProvider.cs # ClientDependency.Core/FileRegistration/Providers/StandardRenderer.cs # build/ClientDependency.nuspec
# Conflicts: # build/ClientDependency.nuspec
# Conflicts: # appveyor.yml # src/ClientDependency.Coffee/CoffeeWriter.cs # src/ClientDependency.Core/BasicFile.cs # src/ClientDependency.Core/ClientDependency.Core.csproj # src/ClientDependency.Core/ClientDependencyAttribute.cs # src/ClientDependency.Core/CompositeFiles/CompositeDependencyHandler.cs # src/ClientDependency.Core/CompositeFiles/Providers/BaseCompositeFileProcessingProvider.cs # src/ClientDependency.Core/CompositeFiles/Providers/CompositeFileProcessingProvider.cs # src/ClientDependency.Core/Config/ClientDependencySettings.cs # src/ClientDependency.Core/Config/DnnConfiguration.cs # src/ClientDependency.Core/Controls/ClientDependencyInclude.cs # src/ClientDependency.Core/Controls/ClientDependencyLoader.cs # src/ClientDependency.Core/Controls/HtmlInclude.cs # src/ClientDependency.Core/CssHelper.cs # src/ClientDependency.Core/DependencySorter.cs # src/ClientDependency.Core/FileRegistration/Providers/BaseFileRegistrationProvider.cs # src/ClientDependency.Core/FileWriters.cs # src/ClientDependency.Core/IClientDependencyFile.cs # src/ClientDependency.Core/IClientDependencyFileExtensions.cs # src/ClientDependency.Core/Module/ResponseFilterStream.cs # src/ClientDependency.Core/Module/RogueFileFilter.cs # src/ClientDependency.Core/SimpleCompressor.cs # src/ClientDependency.Less/LessWriter.cs # src/ClientDependency.SASS/SassWriter.cs # src/ClientDependency.TypeScript/TypeScriptWriter.cs # src/ClientDependency.UnitTests/CssImportStatementsTest.cs
# Conflicts: # src/ClientDependency.Core/CssHelper.cs
# Conflicts: # appveyor.yml
mitchelsellers
approved these changes
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This repo is currently based on the 1.9.2 release of https://github.com/Shazwazza/ClientDependency.
This PR includes changes from 1.9.3 to 1.9.10.