Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Build to Create ClientDependency.Core nupkg #2

Merged
merged 2 commits into from
May 14, 2018

Conversation

SkyeHoefling
Copy link

Updated project/build to support changes for dnnsoftware/Dnn.Platform

  • Created new sln file for building just the ClientDependency.Core project which is used by the Dnn Platform. This new sln file excludes projects that were causing build issues
  • Updated build script to to comment out copy commands that were failing for projects we don't care about for the platform
  • Added new appveyor.yml file for a shared build configuration that exports the nupkg files as part of the build.
  • Configured appveyor project NuGet feed (this needs to be discussed a little more)
    • I am not 100% sure what our plan is for releasing the artifacts as NuGets

Versioning:

  • I followed the current ClientDependency versioning strategy starting at version 1.8.4, if we would like to change this we can simply just update teh appveyor.yml file.

Fixes: dnnsoftware/Dnn.Platform#2061

@SkyeHoefling SkyeHoefling changed the title Updated Build to Create Core nupkg Updated Build to Create ClientDependency.Core nupkg May 13, 2018
@tpluscode
Copy link

Added new appveyor.yml file for a shared build configuration that exports the nupkg files as part of the build.

👍

Fixes: dnnsoftware/Dnn.Platform#2061

Not, we'll still have to remove the binary from the repo and reference the package.

I followed the current ClientDependency versioning strategy starting at version 1.8.4, if we would like to change this we can simply just update the appveyor.yml file.

Yes, this is just good enough. Shall we merge in changes from the origin, we'd just bump it to a matching value.

Configured appveyor project NuGet feed (this needs to be discussed a little more)

I think we will for the time being continue with the MyGet feed and trigger the deployment manually. I will set up the environment on AppVeyor and then it's just one or two clicks to have the build artifact pushed.

@tpluscode tpluscode merged commit 644f1fd into dnnsoftware:dnn May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants