Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new default theme #5893

Merged
merged 36 commits into from
Dec 24, 2023

Conversation

david-poindexter
Copy link
Contributor

Summary

This PR implements the new default theme for DNN 10. In addition to this PR, there will be additional PRs to handle updates to the Default and Blank templates. There will also be updates to DNN 10 default.css that will warrant additional PR(s) to the theme to remove additional CSS overhead. Some other small refinements will also warrant additional PRs. ;-)

Highlights:

  • Minimal package dependencies (will ultimately be all devDependencies once normalize.css can be removed)
  • Build system using rollup.js (https://rollupjs.org/)
  • Browsersync for better local developer experience (https://browsersync.io/)
  • No CSS Framework
  • SCSS compilation for minified CSS output
  • TypeScript source with transpiled minified JavaScript output
  • Preloading of fonts
  • No jQuery if popups are disabled (i.e., the SEARCH skin object is not used)

image

image

image

david-poindexter and others added 22 commits November 4, 2023 03:23
This allows packaging our theme using rollup.
Added rollup own plugin to handle packaging
Also removed registers for controls that were removed in DNN10.
Fixed a Browsersync issue with the Persona Bar
This could cause confusion and users to accidently perform batch operations (like deletions) by accident on items they were not expecting to be selected.

Closes dnnsoftware#5758
Ensures the yarn cache folder exists before doing yarn caching
…hange

Fixed an issue that kept rm items selected after changing folders
@david-poindexter david-poindexter self-assigned this Dec 22, 2023
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple minor things

DNN Platform/Skins/Aperture/Aperture.sln Outdated Show resolved Hide resolved
DNN Platform/Skins/Aperture/README.md Outdated Show resolved Hide resolved
DNN Platform/Skins/Aperture/partials/_footer.ascx Outdated Show resolved Hide resolved
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@david-poindexter
Copy link
Contributor Author

I have no clue why this build is failing in Azure, as it is working fine locally. @valadas and I both made a few guesses, but none of them worked. The error is so obscure, we have no clue where it is coming from. @bdukes any ideas/clues?

@david-poindexter
Copy link
Contributor Author

Yay - the build issue is now resolved - for all those who sent prayers up for me, thank you!!!

@valadas valadas merged commit 3931173 into dnnsoftware:release/10.0.0 Dec 24, 2023
4 checks passed
@david-poindexter david-poindexter deleted the dnn10-theme branch December 25, 2023 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants