-
Notifications
You must be signed in to change notification settings - Fork 754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement new default theme #5893
Merged
valadas
merged 36 commits into
dnnsoftware:release/10.0.0
from
david-poindexter:dnn10-theme
Dec 24, 2023
Merged
Implement new default theme #5893
valadas
merged 36 commits into
dnnsoftware:release/10.0.0
from
david-poindexter:dnn10-theme
Dec 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows packaging our theme using rollup.
Added rollup own plugin to handle packaging
Also removed registers for controls that were removed in DNN10.
Fixed a Browsersync issue with the Persona Bar
This could cause confusion and users to accidently perform batch operations (like deletions) by accident on items they were not expecting to be selected. Closes dnnsoftware#5758
Ensures the yarn cache folder exists before doing yarn caching
…hange Fixed an issue that kept rm items selected after changing folders
valadas
requested changes
Dec 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple minor things
Co-authored-by: Daniel Valadas <[email protected]>
valadas
approved these changes
Dec 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
…into dnn10-theme
… instead of DotNetNuke
mitchelsellers
approved these changes
Dec 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the new default theme for DNN 10. In addition to this PR, there will be additional PRs to handle updates to the
Default
andBlank
templates. There will also be updates to DNN 10default.css
that will warrant additional PR(s) to the theme to remove additional CSS overhead. Some other small refinements will also warrant additional PRs. ;-)Highlights:
normalize.css
can be removed)rollup.js
(https://rollupjs.org/)