Fix: 🐛 Amélioration de quelques composants suite audit RGAA #982
Conversation
✅ Deploy Preview for vue-dsfr-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
vincentlaine
force-pushed
the
fix/rgaa
branch
from
259a118 to
41db3c9
Compare
❌ Deploy Preview for vue-dsfr failed.
|
✅ Deploy Preview for docs-vue-dsfr ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
vincentlaine
force-pushed
the
fix/rgaa
branch
from
41db3c9 to
e523d0a
Compare
✅ Deploy Preview for demo-vue-dsfr ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| :aria-expanded="expanded" | ||
| :aria-controls="breadcrumbId" |
There was a problem hiding this comment.
Pourquoi supprimer ces attributs ?
There was a problem hiding this comment.
Je suis pas expert en accessibilité mais c'était dans les recommandations du rapport :
Problème
● 7.1 - majeur : présence d’un état plié (aria-expanded=”false”) non pertinent
Solution
● Supprimer l’attribut aria-expanded
● Supprimer l’attribut aria-controls
There was a problem hiding this comment.
C’est très étrange. Je vais me renseigner, je te tiens au courant, merci !
There was a problem hiding this comment.
Il faut remplacer le v-show par v-if, ce sera plus propre et ça respectera les recommandations (le bouton ne sera pas rendu)
There was a problem hiding this comment.
J'ai pas vu le mail de github passé, c'est bon je viens de le faire !
vincentlaine
force-pushed
the
fix/rgaa
branch
from
e523d0a to
c77fb1d
Compare
| :aria-expanded="expanded" | ||
| :aria-controls="breadcrumbId" |
There was a problem hiding this comment.
Il faut remplacer le v-show par v-if, ce sera plus propre et ça respectera les recommandations (le bouton ne sera pas rendu)
…g pour accessibilité
vincentlaine
force-pushed
the
fix/rgaa
branch
from
c77fb1d to
d47d61c
Compare
|
🎉 This PR is included in version 7.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
No description provided.