fix: 🐛 DsfrSideMenu balise titre RGAA 8.9.1 NC #991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vue-dsfr-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
MaitreManuel
force-pushed
the
dsfr-side-menu-title-not-text-tag
branch
from
f227567 to
48b4d0e
Compare
👷 Deploy request for vue-dsfr pending review.Visit the deploys page to approve it
|
✅ Deploy Preview for docs-vue-dsfr ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for demo-vue-dsfr ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
laruiss
approved these changes
Dec 18, 2024
|
🎉 This PR is included in version 7.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello (it's me again),
Autre composant qui nous remonte une anomalie RGAA et qui est présente sur le DSFR de base, le Menu Latéral.
Dans notre implémentation, la recommandation est de mettre un
<h2>, mais je pense que de laisser la liberté au développeur de choisir son tag est plus pertinent.Merci d'avance !