-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kubernetes Driver: switch to 'StatefulSet' from 'Deployment' #2938
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: ArielLahiany <[email protected]>
Signed-off-by: ArielLahiany <[email protected]>
I avoided using StatefulSet because creating StatefulSet pods was quite slow at that time due to non-parallelizability. |
}, | ||
ObjectMeta: metav1.ObjectMeta{ | ||
Namespace: opt.Namespace, | ||
Name: opt.Name, | ||
Labels: labels, | ||
Annotations: annotations, | ||
}, | ||
Spec: appsv1.DeploymentSpec{ | ||
Spec: appsv1.StatefulSetSpec{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
podManagementPolicy
should be set to Parallel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also please make sure to measure the startup time of the pods with a good number of replicas (around 5-10?), and there is no significant delay compared to Deployment
Signed-off-by: ArielLahiany <[email protected]>
@AkihiroSuda |
Needs |
I've switched the Kubernetes driver object to 'StatefulSet' from 'Deployment' In order to support long-living persistent data directories between restart, and to meet the needs of the following issue: #2056
Please let me know if there are any other changes that are required, or if a different PR format is required.
Thank you.