Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes Driver: switch to 'StatefulSet' from 'Deployment' #2938

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ArielLahiany
Copy link

I've switched the Kubernetes driver object to 'StatefulSet' from 'Deployment' In order to support long-living persistent data directories between restart, and to meet the needs of the following issue: #2056
Please let me know if there are any other changes that are required, or if a different PR format is required.
Thank you.

@AkihiroSuda
Copy link
Collaborator

I avoided using StatefulSet because creating StatefulSet pods was quite slow at that time due to non-parallelizability.
Has the situation changed?

},
ObjectMeta: metav1.ObjectMeta{
Namespace: opt.Namespace,
Name: opt.Name,
Labels: labels,
Annotations: annotations,
},
Spec: appsv1.DeploymentSpec{
Spec: appsv1.StatefulSetSpec{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

podManagementPolicy should be set to Parallel

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please make sure to measure the startup time of the pods with a good number of replicas (around 5-10?), and there is no significant delay compared to Deployment

@ArielLahiany
Copy link
Author

@AkihiroSuda
I've tested that logic on a freshly-installed vanilla K3s and everything seems to work as required.
I believe that the PR is failing duo to way that the GitHub Action is deploying the cluster.
How can we processed and move that PR along?

@AkihiroSuda
Copy link
Collaborator

ERROR: expected 1 replicas to be ready, got 0

Needs kubectl get pod -o yaml and kubectl logs for further analysis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants