Introduce support for secrets and configs uid|gid|mode by using copy vs bind mount #12625
+231
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
force-pushed
the
copy_config_secret
branch
from
a271484 to
4b26c48
Compare
ndeloof
changed the title
Signed-off-by: Nicolas De Loof <[email protected]>
ndeloof
force-pushed
the
copy_config_secret
branch
from
4b26c48 to
2859d6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Prefer
copystrategy when config/secret mount is set with uid/gid/mode (which a bind mount can't implement)Related issue
fixes #12270
also see #12251
(not mandatory) A picture of a cute animal, if possible in relation to what you did