build: use arm-native gha runners for distributed multi-platform #21854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/build
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dvdksn
added
the
status/do-not-merge
dvdksn
force-pushed
the
gha-native-arm-runners
branch
from
106b598 to
b0ef15d
Compare
crazy-max
reviewed
Jan 20, 2025
Comment on lines
287
to
288
| "linux/arm/v6", | ||
| "linux/arm/v7", |
There was a problem hiding this comment.
I think we could keep the platforms as they can build natively on arm64 runners. So maybe change:
runs-on: ${{ matrix.platform == 'linux/arm64' && 'ubuntu-24.04-arm' || 'ubuntu-latest' }}
to
runs-on: ${{ startsWith(matrix.platform, 'linux/arm') && 'ubuntu-24.04-arm' || 'ubuntu-latest' }}
Signed-off-by: David Karlsson <[email protected]>
dvdksn
force-pushed
the
gha-native-arm-runners
branch
from
b0ef15d to
949d060
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These runners are currently in public preview: https://github.com/orgs/community/discussions/148648